Flocke wrote: ↑Sun Apr 18, 2021 11:37 am
However entering some numbers in some other menus I found a casting error that might be by my changes. But I will check on this another day.
ue_casting_error.jpg
From further testing, debugging and code investigation, this bug was limited to MaxPopOrBonGUI. In the UE log the error reads like this:
Code: Select all
Ultimate Editor 0.7.2dev5c - 23:51:20 20.04.2021
java.lang.ClassCastException: class java.lang.Double cannot be cast to class java.lang.Float (java.lang.Double and java.lang.Float are in module java.base of loader 'bootstrap')
at ue.gui.stbof.MaxPopOrBonGUI.finalWarning(MaxPopOrBonGUI.java:306)
at ue.gui.MainWindow.showPanel(MainWindow.java:91)
at ue.gui.MainMenu$OpenEdit.actionPerformed(MainMenu.java:587)
As I've found, this was not caused by a code change, but likely by the newer compiler or a change in the java.base library.
But I fixed it now.
Lathon wrote: ↑Tue Apr 20, 2021 8:49 pm
Confirmed it's fixed now!
I also finished up cleaning up the project warnings. There should not be anymore
Cool!
With that project finished, I hope you don't mind me to review your changes and e.g. clean up the tab-space indention mess.
For code review btw it is best to work on a separate branch and issue a pull request in GitLab.
But a commit comparison, skipping the stbof save files I touched, works just as well this time:
https://gitlab.com/stbotf/ultimate-edit ... a0a9c42fa9
Regarding the code indention, as I've noticed it is messed in the whole UE project. When viewing the source in the web editor or some git compare, it often becomes quite hard to read when different tab indention is used. Best go either the tab or the space character route.
In UE it looks to be half way either route.
For myself I am used to use space characters, cause when ppl use different tab-indention, it always breaks when you write a second column of comments or the like. And for editor compatibility I don't like to switch tab indention when e.g. I include some library with a different indention.
I however needed to configure Eclipse for this in the Window-Preferences, and both change the Text-Editor indention and add a new Java Code Style:
- eclipse_text_editor_indention.jpg (34.39 KiB) Viewed 3558 times
- eclipse_java_style_indention.jpg (63.55 KiB) Viewed 3558 times
As you can see there are lots of other possible style configurations. I suggest we try to match it with what is mostly used in the UE source.
I havn't looked much into this yet though.
On the other hand I am thinking about switching to another IDE. Even though Eclipse is told to be the most used Java IDE, I rather prefer to code with "Visual Studio Code" or something. Not sure on it yet. Luckily with the gradle build tools it should not be much of an issue to work with multiple IDEs.
edit: Visual Code -> Visual Studio Code I meant