Page 1 of 1

minor race hidden (from diplomacy) - bug fix

Posted: Sun Oct 04, 2009 11:48 am
by Spocks-cuddly-tribble
Good news, using the new knowledge gained from the Ferengi (free) trade routes code I've found a fix for one of the most annoying bugs of BotF. :)

As speculated here, when signing trade treaties, the entry at [systInfo+3Fh] can prevent the first contact with unknown minor races (although by encounter of independent minor-ships it's still possible).

The bugged code hides in sub_46A770 and can be overridden quite easy by removing of the jump statement at 46A7F7:


In trek.exe at 0x69BF7


change:

0F 85 7A 00 00 00

to:

90 90 90 90 90 90


That's all.


No more worrying about signing of treaties with other empires. :)

Posted: Sun Oct 04, 2009 3:49 pm
by Flocke
wonderful! :D
great discoveries you have :)

Posted: Sun Oct 04, 2009 5:46 pm
by thunderchero
I agree great find,

Good thing I am so lazy and 1.0.3 update is not completed yet, so it can be added. :wink:

thunderchero

Posted: Sun Oct 04, 2009 8:57 pm
by SpiN
This bug was rally anoying! thanks for solving it. Also I think Spocks-cuddly-tribble deserves the Code Master title for all his work.

Posted: Mon Oct 05, 2009 12:21 am
by Martok
That's awesome! Much kudos are in order for SCT. You, sir, are one of the greats. 8)

thunderchero wrote:
SpiN wrote:This bug was rally anoying! thanks for solving it. Also I think Spocks-cuddly-tribble deserves the Code Master title for all his work.
I have offered it to him and he declined. :? (this was about same time Gowron and DCER was given honor)

I hope he changes his mind :wink:

thunderchero

I really hope he changes his mind as well. He truly merits the title IMHO, even if he feels he doesn't. :)

Posted: Mon Oct 05, 2009 3:26 am
by stardust
Another excellent find, nice one :)

Time to lock up your minor races because I sense a Biblical level of bribery going on in MP now :twisted:

Posted: Mon Oct 05, 2009 4:07 pm
by Tethys
this is awesome... ive always hated declaring war on my allies and never being able to bribe their minors away from them :twisted:

Posted: Tue Oct 06, 2009 2:09 pm
by eber3
Oh, this is awsome. I hope everybody updates their mods for this fix. This has always been my biggest complaint with botf.

Posted: Wed Oct 07, 2009 10:52 am
by DCER
Very nice, this was long overdue. Great work!

Posted: Thu Oct 08, 2009 1:15 pm
by Peter1981
you know for years and now nearly a decade i've played as the feds and everytime in a game with minors i've played i've always rejected lucrative friendship treaties if my intelligence reports showed minor races with in that empire. Wll Done it is truly an great improvment to the diplomacy :D

Posted: Mon Oct 12, 2009 1:57 am
by Darth_Windu
Problem solved. :-) I downloaded Jokers patch and the numbers all lined up properly. Thanks for all of the help guys.

Posted: Sat Dec 05, 2009 8:32 am
by Gowron
Congratulations, S.C. Tribble, this has really been one of the most sought-after bugfixes. And also looking at your other recent research, like the phantom dilithium fix and the Ferengi free trade route code, I think your new rank is really hard-earned, and I'm happy to see that we have a third code master now :)
Outstanding work, thank you very much :)

My BOP to-do list just exploded ^^

Posted: Sat Dec 05, 2009 11:46 am
by RazorsEdge
Well done indeed. The devil is in the details. Bravissimo!