All in one 2.0.1 beta 5 available

You can talk about anything. (please read forum rules before posting)

Moderator: thunderchero

User avatar
Flocke
BORG Trouble Maker
BORG Trouble Maker
Posts: 3197
Joined: Sun Apr 27, 2008 2:00 am
Location: Hamburg, Germany
Contact:

Re: All in one 2.0.1 beta 5 available

Post by Flocke »

Spocks-cuddly-tribble wrote: Sat Aug 20, 2022 5:47 pm And the Cardassians are considered bad treaty partners....
citing the rules of acquisition:
17: "A contract is a contract is a contract... but only between Ferengi"
21: "Never place friendship above profit."
34: "War is good for business."
76: "Every once in a while, declare peace. It confuses the hell out of your enemies."
200: "A Ferengi chooses no side but his own."
202: "The justification for profit is profit."

foolish Romulans :lol:
User avatar
Spocks-cuddly-tribble
Code Master
Code Master
Posts: 1884
Joined: Sun Apr 27, 2008 2:00 am

Re: All in one 2.0.1 beta 5 available

Post by Spocks-cuddly-tribble »

Image
Image

Still love this patch. For me that helped so much. :up:


I noticed some vanilla GUI gliches. Not sure if they are easy to fix.

Total credits missing when buying upgrade (removing line break might work?):

upgrade_total_credits_missing.png
upgrade_total_credits_missing.png (63.99 KiB) Viewed 1845 times

Missing destruction reports when losing systems:

system_lost_glitch.png
system_lost_glitch.png (483.1 KiB) Viewed 1845 times
I don't know how many bugs is too many but that point is reached somewhere before however many in BotF is.
User avatar
thunderchero
Site Administrator aka Fleet Admiral
Site  Administrator aka Fleet Admiral
Posts: 7849
Joined: Fri Apr 25, 2008 2:00 am
Location: On a three month training mission, in command of the USS Valiant.

Re: All in one 2.0.1 beta 5 available

Post by thunderchero »

Spocks-cuddly-tribble wrote: Sat Aug 27, 2022 2:34 pm
I noticed some vanilla GUI gliches. Not sure if they are easy to fix.

Total credits missing when buying upgrade (removing line break might work?):

Missing destruction reports when losing systems:
here is fix for buy dialog for klingons slight increase in text area in wdf
buy.jpg
buy.jpg (84.35 KiB) Viewed 1708 times
kbuydlg.zip
(288 Bytes) Downloaded 26 times
without a saved game to duplicate issue of Missing destruction reports it is hard to tell issue.
but if text not displaying due to text length it would also be an easy fix like kbuydlg
iirc this does not happen often it might be a code issue?
User avatar
Spocks-cuddly-tribble
Code Master
Code Master
Posts: 1884
Joined: Sun Apr 27, 2008 2:00 am

Re: All in one 2.0.1 beta 5 available

Post by Spocks-cuddly-tribble »

thunderchero wrote: Sun Sep 11, 2022 9:50 amfix for buy dialog for klingons slight increase in text area in wdf
Nice one for ECM. So moving textarea slightly up did the trick.
thunderchero wrote: Sun Sep 11, 2022 9:50 amwithout a saved game to duplicate issue of Missing destruction reports it is hard to tell issue.
but if text not displaying due to text length it would also be an easy fix like kbuydlg
iirc this does not happen often it might be a code issue?
No (corrupted?) saved game and I don't recall any specifics of that test game, but it happened quite some times (ECM not vanilla, but shouldn't matter).
Yes, a strange issue for wdf. Composite texts should leave out some parts (cf. buy & raid messages) but not display a blank only area.

Same issue with some blank research breakthroughs, also composite text (sience description + allows for): viewtopic.php?p=47307#p47307
Has this been fixed? The guy talks about an english trek.exe, but in many cases his statements were wrong/incomplete, so could be english/shorter texts or a pointer bug in one of the tec_ files. For some reason it affects composite texts only (513D99 sprintf_compose_string?).
I don't know how many bugs is too many but that point is reached somewhere before however many in BotF is.
User avatar
thunderchero
Site Administrator aka Fleet Admiral
Site  Administrator aka Fleet Admiral
Posts: 7849
Joined: Fri Apr 25, 2008 2:00 am
Location: On a three month training mission, in command of the USS Valiant.

Re: All in one 2.0.1 beta 5 available

Post by thunderchero »

Spocks-cuddly-tribble wrote: Sun Sep 11, 2022 6:49 pm Yes, a strange issue for wdf. Composite texts should leave out some parts (cf. buy & raid messages) but not display a blank only area.
the buy dialog is different it uses 1 lexicon for "Buy upgrade from %1 to %2 for %d3 credits?"
and different lexicon for "You have %d credits."
so the first part is able to display, but if text is all together by (code or lexicon) nothing will display?
User avatar
Spocks-cuddly-tribble
Code Master
Code Master
Posts: 1884
Joined: Sun Apr 27, 2008 2:00 am

Re: All in one 2.0.1 beta 5 available

Post by Spocks-cuddly-tribble »

thunderchero wrote: Sun Sep 11, 2022 7:42 pmif text is all together by (code or lexicon) nothing will display?
Most raid messages, destruction reports and research breakthroughs are composed of different (sometimes also composed) sub-strings, but only a few of the destruction reports (iirc only for system lost, not conquered) and research breakthroughs are blank (vs incomplete).

Yes, might be a different code/way of composing the text(s) before passing to the wdf (treated as one string and omitted by wdf as a whole if too large).

Testable by increasing the cumulated total length of two+ substrings beyond the wdf display limit (blank or incomplete?).
I don't know how many bugs is too many but that point is reached somewhere before however many in BotF is.
User avatar
thunderchero
Site Administrator aka Fleet Admiral
Site  Administrator aka Fleet Admiral
Posts: 7849
Joined: Fri Apr 25, 2008 2:00 am
Location: On a three month training mission, in command of the USS Valiant.

Re: All in one 2.0.1 beta 5 available

Post by thunderchero »

just looking at *edialog.wdf the Klingons have the smallest area due to gui style

cards 300 x 221
ferengi 350 x 255
feds 275 x 221
klingons 248 x 272
romulans 282 x 238

here is a test klingon files
kedialog.wdf and edited ke_msg.tga
event.zip
(201.05 KiB) Downloaded 34 times
new text size 295 x 289
event.jpg
event.jpg (227.99 KiB) Viewed 1658 times
EDIT;
Spocks-cuddly-tribble wrote: Sun Sep 11, 2022 6:49 pm Same issue with some blank research breakthroughs, also composite text (sience description + allows for): viewtopic.php?p=47307#p47307
Has this been fixed? The guy talks about an english trek.exe, but in many cases his statements were wrong/incomplete, so could be english/shorter texts or a pointer bug in one of the tec_ files. For some reason it affects composite texts only (513D99 sprintf_compose_string?).
I took a look at this issue, and German looks to have a code issue? :shock:

Klingon tech 1 -> tech 2 construction uses lexicon index 511 for future tech?

this happens also on weapons all tech advancements in German, strange thing is weapons shows sociology advancements text after tech 4?
tech4.jpg
tech4.jpg (216.34 KiB) Viewed 1627 times
EDIT2;

I fixed the weapon issue above tech 4 by editing techdesc.tec and techtree.tec (weapons and sociology desc reversed) on german, but english has same issue in files but no issue in game? :shock:

but future tech issue still happening on german;
construction 1 -> 2
weapons 1 -> 2
weapons 2 -> 3
User avatar
Spocks-cuddly-tribble
Code Master
Code Master
Posts: 1884
Joined: Sun Apr 27, 2008 2:00 am

Re: All in one 2.0.1 beta 5 available

Post by Spocks-cuddly-tribble »

thunderchero wrote: Sun Sep 11, 2022 11:16 pm just looking at *edialog.wdf the Klingons have the smallest area due to gui style

cards 300 x 221
ferengi 350 x 255
feds 275 x 221
klingons 248 x 272
romulans 282 x 238
By pixels total the feds area is the smallest (even roms is smaller than kling) but font size vs viewable lines might be a different matter?

thunderchero wrote: Sun Sep 11, 2022 11:16 pmI took a look at this issue, and German looks to have a code issue? :shock:

tech 1 -> tech 2 construction uses lexicon index 511 for future tech?

this happens also on weapons all tech advancements in German, strange thing is weapons shows sociology advancements text after tech 4?

I fixed the weapon issue above tech 4 by editing techdesc.tec and techtree.tec (weapons and sociology desc reversed) on german, but english has same issue in files but no issue in game? :shock:

but future tech issue still happening on german;
construction 1 -> 2
weapons 1 -> 2
weapons 2 -> 3
Nice work, but I suspect stbof.res file errors, not a trek.exe bug.

I don't recall sociology during 7 years usage of my german BotF 1.0.2 CD rom version. And I should have noticed that (Flocke or any other old school german user?).

Here is my original 1.0.2 german tec files with deviations for comparison (IIRC german AFC iso was not from 1.0.2?):
german_102.zip
(887.85 KiB) Downloaded 32 times

Maybe some of the deviations looking like junk have an unknown meaning?

techdesc.tec has no deviations from current AIO german but here is the whole 1.0.2 german stbof.res: https://workupload.com/file/xueHJuxZbvb
I don't know how many bugs is too many but that point is reached somewhere before however many in BotF is.
User avatar
thunderchero
Site Administrator aka Fleet Admiral
Site  Administrator aka Fleet Admiral
Posts: 7849
Joined: Fri Apr 25, 2008 2:00 am
Location: On a three month training mission, in command of the USS Valiant.

Re: All in one 2.0.1 beta 5 available

Post by thunderchero »

Spocks-cuddly-tribble wrote: Mon Sep 12, 2022 2:24 pm By pixels total the feds area is the smallest (even roms is smaller than kling) but font size vs viewable lines might be a different matter?
correct but klingons was the narrowest area so more lines had to use 2 line?
Spocks-cuddly-tribble wrote: Mon Sep 12, 2022 2:24 pm Nice work, but I suspect stbof.res file errors, not a trek.exe bug.
I agree it is a res file issue, example if I add only the english techtree.tec to german install

it will no longer display future tech error, but as expected all text is misaligned.

but for the life of me I can not fix issue. It my require a complete re-write of german techtree.tec

NOTE:
techtree.tec format each entry 0x47 (72 bytes)

UE will write 00's to 0x14 - 0x28
and area 0x30 - 0x36
of each entry
unused data?

EDIT:
I found what was causing issue of future tech text displaying. :grin:

when the next entry has ä it would display future tech text
User avatar
Spocks-cuddly-tribble
Code Master
Code Master
Posts: 1884
Joined: Sun Apr 27, 2008 2:00 am

Re: All in one 2.0.1 beta 5 available

Post by Spocks-cuddly-tribble »

Means the german blank, future & sociology tech display-glitches are connected via the same 'ä' mutation/umlaut?
What about ö/ü e.g. Öko-Modifikation?
thunderchero wrote: Mon Sep 12, 2022 3:37 pmtechtree.tec format each entry 0x47 (72 bytes)

UE will write 00's to 0x14 - 0x28
and area 0x30 - 0x36
of each entry
unused data?
0x28 -> looks like an index 0-4C (might be unused)
I don't know how many bugs is too many but that point is reached somewhere before however many in BotF is.
User avatar
thunderchero
Site Administrator aka Fleet Admiral
Site  Administrator aka Fleet Admiral
Posts: 7849
Joined: Fri Apr 25, 2008 2:00 am
Location: On a three month training mission, in command of the USS Valiant.

Re: All in one 2.0.1 beta 5 available

Post by thunderchero »

Spocks-cuddly-tribble wrote: Mon Sep 12, 2022 5:53 pm What about ö/ü e.g. Öko-Modifikation?
just tested and tech changed and displayed properly with Öko-Modifikation unchanged.

here is my current German tech error patch files.
tech.zip
(9.07 KiB) Downloaded 36 times
User avatar
Spocks-cuddly-tribble
Code Master
Code Master
Posts: 1884
Joined: Sun Apr 27, 2008 2:00 am

Re: All in one 2.0.1 beta 5 available

Post by Spocks-cuddly-tribble »

ä should be replaced with ae:
techtree.zip
(1.69 KiB) Downloaded 31 times
I don't get the changes in techdesc. If weapon issue above tech 4 is due to one of the ä entries it shouldn't be needed using ae?
I don't know how many bugs is too many but that point is reached somewhere before however many in BotF is.
User avatar
thunderchero
Site Administrator aka Fleet Admiral
Site  Administrator aka Fleet Admiral
Posts: 7849
Joined: Fri Apr 25, 2008 2:00 am
Location: On a three month training mission, in command of the USS Valiant.

Re: All in one 2.0.1 beta 5 available

Post by thunderchero »

Spocks-cuddly-tribble wrote: Mon Sep 12, 2022 6:59 pm I don't get the changes in techdesc. If weapon issue above tech 4 is due to one of the ä entries it shouldn't be needed using ae?
answer is UE make changes that is not needed to make files look more logical (description pointers not in same order as tech list)

here is edited cd 1.0.2 without desc changes or deleting unused data (edited techdesc.tec not needed)
techtree.zip
(1.77 KiB) Downloaded 24 times
User avatar
Spocks-cuddly-tribble
Code Master
Code Master
Posts: 1884
Joined: Sun Apr 27, 2008 2:00 am

Re: All in one 2.0.1 beta 5 available

Post by Spocks-cuddly-tribble »

I think it's the convert a-z to capitals (A-Z) code (61h-7A -20h = 41h-5A) missing german umlauts ä,ö,ü (E4,F6,FC), so capital Ä,Ö,Ü don't trigger issue.

sub_51DBBA convert_a_z_to_capitals -> trek.exe workaround for ä only:

51DBCA ja short 51DBD8

@ 51DBD8
cmp al,83
je 51DBCC
jmp 51DBD0
I don't know how many bugs is too many but that point is reached somewhere before however many in BotF is.
User avatar
thunderchero
Site Administrator aka Fleet Admiral
Site  Administrator aka Fleet Admiral
Posts: 7849
Joined: Fri Apr 25, 2008 2:00 am
Location: On a three month training mission, in command of the USS Valiant.

Re: All in one 2.0.1 beta 5 available

Post by thunderchero »

Spocks-cuddly-tribble wrote: Tue Sep 13, 2022 12:10 am I think it's the convert a-z to capitals (A-Z) code (61h-7A -20h = 41h-5A) missing german umlauts ä,ö,ü (E4,F6,FC), so capital Ä,Ö,Ü don't trigger issue.

sub_51DBBA convert_a_z_to_capitals -> trek.exe workaround for ä only:

51DBCA ja short 51DBD8

@ 51DBD8
cmp al,83
je 51DBCC
jmp 51DBD0
That looks to have fixed German tech description display issue, and using OllyDbg did not hurt my head too much. :???:

would this be only for German version or would code changes have no effect English version? I expect code change to be ignored as long as no ä,ö,ü is present.

Code: Select all

51DBCA ja short 51DBD8
at 51DBCA 0x11cfca 77 04 -> 77 0C


@ 51DBD8
cmp al,83 
je 51DBCC
jmp 51DBD0
at 51DBD8 0x11cfd8 00 00 00 00 00 00 -> 3C 83 74 F0 EB F2
Post Reply

Return to “General Chat”