using 2 training facilities

This forum is for outdated or irrelevant Modding Information that may or may not be 3 months old.

Moderator: thunderchero

Post Reply
User avatar
DOT
Lieutenant-Commander
Lieutenant-Commander
Posts: 100
Joined: Tue Dec 23, 2008 3:00 am
Location: 49°N, 8°E

using 2 training facilities

Post by DOT » Wed Sep 01, 2010 11:35 am

Hello,

when using more than one training facility there are some strange things going on (which imho counts as proof that the related subroutine was not programmed by a vulcan).

- if only the first building is powered, training don't work (Gowron reported this with his BoP)
- if the second building has no energy value, training don't work
- if only the second facility is powered, training value is the sum of both facilities

In the next days I will see what happens if 3 training facilities were build within one system and report.
life long and prosper

User avatar
Peter1981
Rear-Admiral
Rear-Admiral
Posts: 1118
Joined: Tue May 06, 2008 2:00 am
Location: England

Post by Peter1981 » Wed Sep 01, 2010 2:20 pm

@DOT are you talking about a modded buildings list?

- if so -- then the game probably was never ment to work like this.
- if not - then the game has yet another bug ;) good work on finiding this -- hope you have as much sucess resolving it.

User avatar
Spocks-cuddly-tribble
Code Master
Code Master
Posts: 729
Joined: Sun Apr 27, 2008 2:00 am

Post by Spocks-cuddly-tribble » Wed Sep 01, 2010 3:59 pm

Hi, friends, long time no see.

Yes, BotF doesn't support more than one training facility without bugs. You must rewrite this code sequence in order to correct that behavior:

Code: Select all

4690DF            call    starID_from_sector_lst
4690E4            movsx   ecx, ax
4690E7            mov     edx, 10h
4690EC            mov     eax, ecx
4690EE            mov     ebx, esp
4690F0            call    add_output_of_same_output_IDs
4690F5            mov     edx, 10h
4690FA            mov     [esp+8], eax
4690FE            mov     eax, ecx
469100            call    check_building_output_id_in_edx
469105            test    eax, eax
469107            jz      exit_no_training
46910D            xor     edx, edx
46910F            mov     eax, ecx
469111            mov     dx, [esp+2]
469116            call    power_up_building?_edx_ID (According to Gowron)
46911B            mov     edx, ecx
46911D            call    some_building_energy_test
469122            test    eax, eax
469124            jz      short exit_no_training
And sorry again for my harsh and unfair words in the past.

I didn't check my PM's, but I have been and always shall be your friend. :)
See you sometime in future.
On the verge of a nervous breakdown? Try the relaxing tribble sounds.

User avatar
Tethys
Past Administrator
Past Administrator
Posts: 2065
Joined: Fri Jul 18, 2008 2:00 am
Location: Your mom's bed ;)
Contact:

Post by Tethys » Thu Sep 02, 2010 2:48 am

*wipes eyes to make sure its real* is that SCT??? :o :mrgreen:
Not for the weak of heart...
Image
GALM <--- GALM/Galaxies Mod

User avatar
Peter1981
Rear-Admiral
Rear-Admiral
Posts: 1118
Joined: Tue May 06, 2008 2:00 am
Location: England

Post by Peter1981 » Thu Sep 02, 2010 2:00 pm

Hello SCT nice to see you keeping an eye on us mear mortals

[quote... for my harsh and unfair words in the past.[/quote] -- no need to say sorry, I never minded in the first place ;)


Thanks for the info gonna take a look at this next week as I'm on holiday from work :)

User avatar
DOT
Lieutenant-Commander
Lieutenant-Commander
Posts: 100
Joined: Tue Dec 23, 2008 3:00 am
Location: 49°N, 8°E

Post by DOT » Thu Sep 02, 2010 2:08 pm

@SCT:
Normally I shy away from such things, but I guess, I can speak as the voice of all the users from this forum when I say:
Welcome back & it's wonderful to see you around again!!

@peter1981:
Yes, I extended the building list a little. But as I wrote before the honor of discovering this strange behavore is not mine.
life long and prosper

Post Reply

Return to “Modding Information Archive”

Who is online

Users browsing this forum: No registered users