minor race hidden (from diplomacy) - bug fix

minor race hidden (from diplomacy) bug (fix); support/discussion/questions

Moderator: thunderchero

Post Reply
User avatar
Spocks-cuddly-tribble
Code Master
Code Master
Posts: 723
Joined: Sun Apr 27, 2008 2:00 am

minor race hidden (from diplomacy) - bug fix

Post by Spocks-cuddly-tribble » Sun Oct 04, 2009 11:48 am

Good news, using the new knowledge gained from the Ferengi (free) trade routes code I've found a fix for one of the most annoying bugs of BotF. :)

As speculated here, when signing trade treaties, the entry at [systInfo+3Fh] can prevent the first contact with unknown minor races (although by encounter of independent minor-ships it's still possible).

The bugged code hides in sub_46A770 and can be overridden quite easy by removing of the jump statement at 46A7F7:


In trek.exe at 0x69BF7


change:

0F 85 7A 00 00 00

to:

90 90 90 90 90 90


That's all.


No more worrying about signing of treaties with other empires. :)
On the verge of a nervous breakdown? Try the relaxing tribble sounds.

User avatar
Flocke
BORG Trouble Maker
BORG Trouble Maker
Posts: 2546
Joined: Sun Apr 27, 2008 2:00 am
Location: Hamburg, Germany
Contact:

Post by Flocke » Sun Oct 04, 2009 3:49 pm

wonderful! :D
great discoveries you have :)

User avatar
thunderchero
Site Administrator aka Fleet Admiral
Site  Administrator aka Fleet Admiral
Posts: 6066
Joined: Fri Apr 25, 2008 2:00 am
Location: On a three month training mission, in command of the USS Valiant.
Contact:

Post by thunderchero » Sun Oct 04, 2009 5:46 pm

I agree great find,

Good thing I am so lazy and 1.0.3 update is not completed yet, so it can be added. :wink:

thunderchero

User avatar
SpiN
Cadet 2nd Year
Cadet 2nd Year
Posts: 9
Joined: Sun Apr 27, 2008 2:00 am

Post by SpiN » Sun Oct 04, 2009 8:57 pm

This bug was rally anoying! thanks for solving it. Also I think Spocks-cuddly-tribble deserves the Code Master title for all his work.

User avatar
Martok
Rear-Admiral
Rear-Admiral
Posts: 1137
Joined: Thu May 01, 2008 2:00 am

Post by Martok » Mon Oct 05, 2009 12:21 am

That's awesome! Much kudos are in order for SCT. You, sir, are one of the greats. 8)

thunderchero wrote:
SpiN wrote:This bug was rally anoying! thanks for solving it. Also I think Spocks-cuddly-tribble deserves the Code Master title for all his work.
I have offered it to him and he declined. :? (this was about same time Gowron and DCER was given honor)

I hope he changes his mind :wink:

thunderchero

I really hope he changes his mind as well. He truly merits the title IMHO, even if he feels he doesn't. :)
"Evil is easy, and has infinite forms." -- Pascal

stardust
Rear-Admiral
Rear-Admiral
Posts: 1381
Joined: Sat Apr 26, 2008 2:00 am
Location: good ole Blighty

Post by stardust » Mon Oct 05, 2009 3:26 am

Another excellent find, nice one :)

Time to lock up your minor races because I sense a Biblical level of bribery going on in MP now :twisted:
Computers! [Expletive deleted]

My 4shared folder

User avatar
Tethys
Past Administrator
Past Administrator
Posts: 2065
Joined: Fri Jul 18, 2008 2:00 am
Location: Your mom's bed ;)
Contact:

Post by Tethys » Mon Oct 05, 2009 4:07 pm

this is awesome... ive always hated declaring war on my allies and never being able to bribe their minors away from them :twisted:
Not for the weak of heart...
Image
GALM <--- GALM/Galaxies Mod

User avatar
eber3
Captain
Captain
Posts: 657
Joined: Sat Apr 26, 2008 2:00 am

Post by eber3 » Tue Oct 06, 2009 2:09 pm

Oh, this is awsome. I hope everybody updates their mods for this fix. This has always been my biggest complaint with botf.

User avatar
DCER
Code Master
Code Master
Posts: 683
Joined: Sat Apr 26, 2008 2:00 am

Post by DCER » Wed Oct 07, 2009 10:52 am

Very nice, this was long overdue. Great work!

User avatar
Peter1981
Rear-Admiral
Rear-Admiral
Posts: 1118
Joined: Tue May 06, 2008 2:00 am
Location: England

Post by Peter1981 » Thu Oct 08, 2009 1:15 pm

you know for years and now nearly a decade i've played as the feds and everytime in a game with minors i've played i've always rejected lucrative friendship treaties if my intelligence reports showed minor races with in that empire. Wll Done it is truly an great improvment to the diplomacy :D

User avatar
Darth_Windu
Lieutenant-Commander
Lieutenant-Commander
Posts: 156
Joined: Sat Jul 19, 2008 2:00 am

Post by Darth_Windu » Mon Oct 12, 2009 1:57 am

Problem solved. :-) I downloaded Jokers patch and the numbers all lined up properly. Thanks for all of the help guys.

User avatar
Gowron
Code Master
Code Master
Posts: 304
Joined: Sat Apr 26, 2008 2:00 am
Location: 50° N, 11° E

Post by Gowron » Sat Dec 05, 2009 8:32 am

Congratulations, S.C. Tribble, this has really been one of the most sought-after bugfixes. And also looking at your other recent research, like the phantom dilithium fix and the Ferengi free trade route code, I think your new rank is really hard-earned, and I'm happy to see that we have a third code master now :)
Outstanding work, thank you very much :)

My BOP to-do list just exploded ^^
A discovery consists in seeing something everybody has seen and at the same time thinking something nobody has thought yet.

User avatar
RazorsEdge
Cadet 1st Year
Cadet 1st Year
Posts: 3
Joined: Sat Nov 21, 2009 3:00 am

Post by RazorsEdge » Sat Dec 05, 2009 11:46 am

Well done indeed. The devil is in the details. Bravissimo!

Post Reply

Return to “minor race hidden (from diplomacy) bug (fix)”

Who is online

Users browsing this forum: No registered users