thunderchero wrote: ↑Sun Apr 15, 2018 9:29 amI have been looking for the location for commands for each combat group. I know I am just missing it or blind
Problem is there are different switch modes in different processing depths.
Special cases:
- vs. monster, station, minor ships, 3+ way battles (with allies?)
- non-combat group
- special checks for selected retreat and ram commands -> triggering of a new command selection loop with changed input values? e.g. at 477E79, 477EA7 & 477FD5
Some examples:
- loc_4784F0: non-combat(armed) vs. ships: assault, evade, retreat & ram
- 4786F5... : group commands vs stations
- ship vs. ship commands for groups 0-2 are taken from data fields ds:5905D4(fast), ds:590674(long range) and ds:590714(slow) via intricate index operations (special case: evade at 478863)
I presume you are selecting ram same as me due to it is a "safe" command for all groups?
No, I just adapted the default code switches at this point.
the main group issue being the support / non-combat group. Since all ship models have at least 1 phaser slot. we can add min ship stats to all support / non-combat ships to allow more "safe" options.
Non-combat group shouldn't be a problem due to the special code switches.
Just edit their special retreat / ram codes for your taste (or leave them alone).
Problem could be the special checks for selected retreat and ram commands -> triggering of a new command selection loop with changed input values? e.g. at 477E79, 477EA7 & 477FD5
Means if we change the retreat command to something other than ram, the code might miss some trigger point information, maybe with side effects like an infinite loop i.e. crash/freeze. So testing/verifying all possible combat constellations might be frustating/time-consuming.
I don't know how many bugs is too many but that point is reached somewhere before however many in BotF is.