Extending the shiplist

[Tethys]

Indeed, good thinking. There is two cases where it might fail:

- removing all minor/monster ships from shiplist (have the monsters shiptech.sst entries?)
- using "building minor ships after membership" patch

BUT, easiest way to make it work would be just one extra single byte edit:

0046F81C  jz   short loc_46F85D (inc ship ID check next or exit) -> loc_46F86B EXIT

Nice trick to depend on

46F970         mov     ax, ds:shipNum_Max_ID

As a programmer I however learned that true while loops are bad coding style.
I'm happy with the current patch I implemented.

Not related directly but related to original topic:
shipNum_Max_ID 5 locations but I think shiplist can be extended up to 65535 max ships.

Code: Select all

Replace:

asm
0046FB81 66 A3 3C 54 5B 00    mov ds:005B543C, ax
0046FB87 66 3D 7D 00          cmp ax, 7Dh
With:

asm
0046FB81 A3 3C 54 5B 00       mov ds:005B543C, eax
0046FB86 3D 7D 00 00 00       cmp eax, 7Dh

This changes a 10-byte block into a 10-byte block again — so no size mismatch, and everything stays aligned.

This is one subroutine out of 5 where shipNum_Max_ID is read or written. All should be changed. Also:

Code: Select all

005B543C ?? ??                   shipNum_Max_ID_word_5B543C dw ?                   ; DATA XREF: shipTech_sst_entry_shipIdEAX_to_edx+30r
005B543C                                                                           ; read_shiplist_sst_46F9C0+30r ...
005B543E ?? ??                           align 10h

align 10h can be used because critical section falls on a 16 bit divisible address by default: no performance hit, no crashes (assuming all code referencing critical section ACTUALLY falls on the 16 bit divisible address and not 2 bytes before it). Change dw to dd. Further adjustments may be necessary for example 0046F808 in build_shiplist_7D sub. That's all I have been able to figure out for now, I will revisit later. UNTESTED

Code: Select all

0046F7FE 0F 84 71 00 00 00                   jz      loc_46F875

becomes

0046F7FE 74 75 90                    jz      loc_46F875
89 44 24 10                         mov     [esp+10h], eax
3D 7D 00 00 00                         cmp     eax, 7Dh  

Why has nobody suggested changing the encoding of the signed value from 2 to 4 bytes? There is enough space, and it looks like it can be done without using relocations. At the very least we should see 32,768 shiplist entries Good luck hitting that limit

Code: Select all

0046F866 83 FA 7D                            cmp     edx, 7Dh        ; Compare Two Operands
0046F869 7C A2                               jl      short loc_46F80D ; Jump if Less (SF!=OF)

The above is the only one yet found which would need relocation, 0F bytes needed 0046F80B and 0046F82D can be adjusted plus 2 bytes, move conditional jl 0046F869, rewrite 0046F86B to EB jump about 4-5 bytes forward to earlier exit.

Code: Select all

00479836 81 C5 F4 01 00 00                   add     ebp, 1F4h       ; 500 unused combat.bin entry size

Is this truly unused? Can these bytes be utilized for extension?

Off topic: why is starname bin with a 125 limit? Is this 125 scans of the map to place names or something?
004B78A4 83 F9 7D cmp ecx, 7Dh ; Compare Two Operands

[Tethys]

I think I see now that al is the problem, with it being so small and as SCT said is used about 150x for ship list. But I think not all of them need to be changed because some of them use ax (enough bytes for intended goal)

On this occasion, I also had another look at extending the shiplist phase II.


Word instead of single-byte registers - not very complicated (excepting possible issues with ship-ID "FF") - but all in all ~200 code sequences would have to be rewritten:

sub_46F940 (read_shiptech_sst) -> 15 calls
sub_46F9C0 (read_shiplist_sst) -> 155 calls

So even with a very optimistic assumption of 5 minutes per code location...

Thereby the following deliberations become more or less moot.

UPDATE: I have inspected all the reference subroutines for

0046F940 read_shipTech_sst_entry_shipIdEAX_to_edx

There looks to be quite a few places where al, cl, and dl should all be extended. Of course there is no room natively to add the preceding opcode, and we cant just use the full eax, ecx, and edx for all locations because of preceding data (garbage data left in the register) and also because most importantly there are ONLY 2 bytes available in shiplist.sst file @ offset 0x66h. At 0x68h there is other data which would mess up a full register (eax or similar) move of the 4 bytes here (garbage in the lower half). So ax is required in these cases (which also require relocating some preceding datas to make room for extra opcodes). Data at 68h appears to be "ship function +68h"; alternatively, I believe movsx/zx can be used and might save some codespace when using eax

I am currently building a list of locations and trying to discern which type is needed (if eax is used with movsx/zx or if we must use ax in certain situations).
List 16 locations for read_shipTech_sst: (location follow by ? need further investigations)

► Show Spoiler

Code: Select all

0044A724 update_GShipList_entry__Ship_switches_x2  88 D3                               mov     bl, dl          ; safe to convert 89 D3 ebx, edx shiplist_ext 
0045267D AutoUpgradeShipStation                    8A 44 34 66                         mov     al, [esp+esi+66h] ; new ship ID shiplist_ext                  
0046F811 build_shiplist_7D                         8A 44 24 10                         mov     al, [esp+10h]   ; mov ax, shiplist_ext                        
0046F945 read_shipTech_sst_entry_shipIdEAX_to_edx  88 C1                               mov     cl, al          ; cx, ax shiplist_ext                         
00479B9A AI_TT_combat_Ratio_to_FPU                 8A 43 52                            mov     al, [ebx+52h]   ; ax, shiplist_ext                            
00497F94 TC_weapon_label__tevent.txt               8A 44 24 66                         mov     al, [esp+66h]   ; ax, shiplist_ext                            
00498177 TC_weapon_label__tevent.txt               8A 44 24 66                         mov     al, [esp+66h]   ; ax, shiplist_ext                            
0049842B TC_weapon_label__tevent.txt               8A 44 24 66                         mov     al, [esp+66h]   ; ax, shiplist_ext                            
004A2C7D TC_commands_weapon_labels__scout_getGroup 8A 84 24 2A 0A 00 00                mov     al, [esp+0A2Ah] ; ax, shiplist_ext             
004A37F9 tactscn_ship_tech_weapon_labels           8A 84 24 26 0A 00 00                mov     al, [esp+0A26h] ; ax, shiplist_ext                            
004D3307 shipTech_structureTech                    8A 84 24 54 01 00 00                mov     al, [esp+154h]  ; ax, shiplist_ext                            
004D4BE7 ship_build_stats?                         8A 84 24 66 08 00 00                mov     al, [esp+866h]  ; ax, shiplist_ext                            
004D6E1F tech_lev_stuff_ships_tga                  8A 46 2A                            mov     al, [esi+2Ah]   ; ax, shiplist_ext                            
004D737C tech_info_tree_stuff                      8A 01                               mov     al, [ecx]       ; 8A > 8B eax, [ecx] shiplist_ext             
004ED1A3 show_station_big_tga_stats                8A 42 2E                            mov     al, [edx+2Eh]   ; ax, shiplist_ext                            
004ED329 show_station_big_tga_stats                8A 84 24 51 06 00 00                mov     al, [esp+651h]  ; ax, shiplist_ext ?                          
004ED36E show_station_big_tga_stats                8A 84 24 51 06 00 00                mov     al, [esp+651h]  ; ax, shiplist_ext ?                          
004FF466 REDEPLOY_Ship_TF_descriptions             8A 45 52                            mov     al, [ebp+52h]   ; ax, shiplist_ext                            
004FF7EC REDEPLOY_Ship_TF_descriptions             8A 84 24 55 0B 00 00                mov     al, [esp+0B55h] ; ax, shiplist_ext ?                          
004FF831 REDEPLOY_Ship_TF_descriptions             8A 84 24 55 0B 00 00                mov     al, [esp+0B55h] ; ax, shiplist_ext ?                          

[Tethys]

List 268 locations for read_shiplist_sst_46F9C0 (might be more or less, some parts not well understood)

► Show Spoiler

Code: Select all

00404584 cmp_AI_shipfuction_values_end                                        8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
0040458E cmp_AI_shipfuction_values_end                                        25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
004045A0 cmp_AI_shipfuction_values_end                                        8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
004045A5 cmp_AI_shipfuction_values_end                                        25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
00406C6C AI_expenses_plus_income?_get_treaty_costs?                           8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
00406CAC AI_expenses_plus_income?_get_treaty_costs?                           8A 40 08                            mov     al, [eax+8]     ; race ID? ax, shiplist_ext2 ? XOR?                                  
00406CB1 AI_expenses_plus_income?_get_treaty_costs?                           88 84 24 48 02 00 00                mov     [esp+248h], al  ; ax, shiplist_ext2 ? XOR 406C78?                                    
00406CCF AI_expenses_plus_income?_get_treaty_costs?                           8A 94 24 48 02 00 00                mov     dl, [esp+248h]  ; shiplist_ext2 ?                                                    
00406CE4 AI_expenses_plus_income?_get_treaty_costs?                           8A 40 2E                            mov     al, [eax+2Eh]   ; ax, shiplist_ext2 +reloc                                           
00406CE9 AI_expenses_plus_income?_get_treaty_costs?                           25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
004083B0 TaskEAX_Target_in_Range_eax1_yes_adrEBX_FlyingTime_dxGShip           8A 46 52                            mov     al, [esi+52h]   ; eax, shiplist_ext2                                                 
004087EE GetTaskforceRangeLevel                                               8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
004087F3 GetTaskforceRangeLevel                                               25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
004088AE Cost_Enemy_Fleet_Area_expBonus_Station_C4_average_CC                 8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
00408938 Cost_Enemy_Fleet_Area_expBonus_Station_C4_average_CC                 8A 41 2E                            mov     al, [ecx+2Eh]   ; eax, shiplist_ext2                                                 
00408B1E Cost_TskSh_ShipUnits_B4_average_BC                                   8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
00408C7F Task_Status_2_GO_merge_TskSh_TFs_by_cloak                            8A 45 52                            mov     al, [ebp+52h]   ; eax, shiplist_ext2                                                 
00408CF7 Task_Status_2_GO_merge_TskSh_TFs_by_cloak                            8A 45 52                            mov     al, [ebp+52h]   ; eax, shiplist_ext2                                                 
0040CAAD get_number_of_shipfunction_edx                                       8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
0040CAB2 get_number_of_shipfunction_edx                                       25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0040CE88 AI_Scrap_Stranded_Task_forces                                        8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0040CFCD AI_TF_try_Scrap_function_edx                                         8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0040D09B AI_TF_try_Scrap_function_edx                                         8A 40 2E                            mov     al, [eax+2Eh]   ; ax, shiplist_ext2 +reloc                                           
0040D0A0 AI_TF_try_Scrap_function_edx                                         25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0040E473 yard_ally_check_REPAIR                                               8A 42 2E                            mov     al, [edx+2Eh]   ; eax, shiplist_ext2                                                 
0040F7A8 Build_Outpost_Starbase                                               8A 40 2E                            mov     al, [eax+2Eh]   ; ax, shiplist_ext2 ? shiplist.sst ID -> cmp +2Ch, 7                 
0040F7AD Build_Outpost_Starbase                                               25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0040FB77 AI_colonize_2_range_distance_check                                   88 D0                               mov     al, dl          ; eax,edx shiplist_ext2                                              
0040FE4B get_best_available_Colonization_Priority?                            88 D0                               mov     al, dl          ; eax,edx shiplist_ext2                                              
004181D9 prepare_new_AIShpUnt_entry                                           8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0041833E aibldshp.shipClassId__store_maintenance                              88 C8                               mov     al, cl          ; ax, cx shiplist_ext2 +reloc ^                                      
0041856A AI_buid_ship_max_20_turns                                            25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
00418856 build_ship_1C_max_20_turns_dil_total                                 25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0041B212 AI_colonize_38_max_limit_modifier_add30                              8A 45 52                            mov     al, [ebp+52h]   ; eax, shiplist_ext2                                                 
0041B89B Tform_38_max_limit_modifier_50turns?                                 8A 42 52                            mov     al, [edx+52h]   ; eax, shiplist_ext2                                                 
0041DB01 bldBase_44_map_distance_3_5_maintenance_cost                         25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0041DC16 AI_bldbase_38__max_limit_tasks_modifier_get_TTs_Range_check          8A 45 52                            mov     al, [ebp+52h]   ; eax, shiplist_ext2                                                 
0041E64C for_invade_18_orders_TF                                              8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0041E9CD Invade_38_max_limit_GShipEDX_to_FPU__modifier_add_0.1_yard_dil       8A 42 52                            mov     al, [edx+52h]   ; eax, shiplist_ext2                                                 
00426B02 cmp_TF_position_task_by_modifier1C_shipfunctions_mask_aialloc_38_max 8A 41 52                            mov     al, [ecx+52h]   ; sst ID eax, shiplist_ext2                                          
0042AA3A Defensive_Consolidation_4sector_war_enemy_eax_0                      8A 40 2E                            mov     al, [eax+2Eh]   ; shiplist.sst Id ax, shiplist_ext2 +reloc                           
0042AA3F Defensive_Consolidation_4sector_war_enemy_eax_0                      25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ? further explor subroutine                          
0042AA8E Defensive_Consolidation_4sector_war_enemy_eax_0                      8A 40 2E                            mov     al, [eax+2Eh]   ; ax, shiplist_ext2, ship ID / shiplist.sst -> +2Ch  cmp 7 possible? 
0042AA93 Defensive_Consolidation_4sector_war_enemy_eax_0                      25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0042AC49 check_sector_TFs_Patrol__cost_armed                                  8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0042AD08 check_sector_TFs_Patrol__cost_armed                                  8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0042AF2F Patrol_ship_costs_needed_vs_enemy_in_sector                          8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
0042AF34 Patrol_ship_costs_needed_vs_enemy_in_sector                          25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0042AFCA Patrol_ship_costs_needed_vs_enemy_in_sector                          8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
0042B03E Patrol_ship_costs_needed_vs_enemy_in_sector                          8A 41 2E                            mov     al, [ecx+2Eh]   ; eax, shiplist_ext2                                                 
0042B891 AI_updated_TF_bitmask_to_eax                                         8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0042B8F6 AI_fleet_check_min_6_ships_set1                                      8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2, shiplist.sst ID from Gshiplist                 
0042BC69 Enemy_TFs_in_sector_to_push1_test_eax1                               8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
0042BD5A enemy_fleet_COST_in_sector_NEXT                                      8A 41 2E                            mov     al, [ecx+2Eh]   ; eax, shiplist_ext2                                                 
0042BE11 enemy_fleet_COST_in_sector_NEXT                                      8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0042C87A Scan_Enemy_Ships_X_Turns_from_Target                                 8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0042C9C3 Scan_Enemy_Ships_X_Turns_from_Target                                 8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
0042CB59 near_target_sector?_enemy_shipcost__raid_harass                      8A 41 2E                            mov     al, [ecx+2Eh]   ; eax, shiplist_ext2                                                 
0042CC76 near_target_sector?_enemy_shipcost__raid_harass                      8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0042CDB5 near_target_sector?_enemy_shipcost__raid_harass                      8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0042CFFA danger_check_power_OBs_SH__distance_speed_checks_NEXT                8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0042D496 System_Threat_Level__4_sectors                                       8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
004346BA Patrol_cost_TskSh_Station_B4_average_BC                              8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
00434734 Patrol_cost_TskSh_Station_B4_average_BC                              8A 42 2E                            mov     al, [edx+2Eh]   ; eax, shiplist_ext2                                                 
00435616 Repair_38_max_limit__Ratio_threshold_check_modifier                  8A 46 52                            mov     al, [esi+52h]   ; eax, shiplist_ext2                                                 
00435DF1 Attack_38_max_limit_tasks_modifier                                   8A 45 52                            mov     al, [ebp+52h]   ; eax, shiplist_ext2                                                 
0043E096 real_Buy_Cost_to_EAX__edx_systInfo80                                 8A 42 10                            mov     al, [edx+10h]   ; eax, shiplist_ext2, ship ID                                        
0043FB71 pos_morale_results_systems                                           8A 41 10                            mov     al, [ecx+10h]   ; eax, shiplist_ext2                                                 
00441AA2 Sumary_Systems_list__turns_in_eax                                    8A 41 10                            mov     al, [ecx+10h]   ; eax, shiplist_ext2                                                 
00441AB0 Sumary_Systems_list__turns_in_eax                                    8A 41 10                            mov     al, [ecx+10h]   ; eax, shiplist_ext2 ?                                               
00441ABE Sumary_Systems_list__turns_in_eax                                                                        loc_441ABE:             ; ax, shiplist_ext2 ? \/                                             
004462DC add_ShipID_edx__systemID_eax                                         88 D8                               mov     al, bl          ; eax,ebx  shiplist_ext2 (bx sign extended ok)                       
00447F1B TaskForceSummary_TURNSTATUS                                          8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
00447F22 TaskForceSummary_TURNSTATUS                                          25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
004482C9 add_shipcosts__Not_5_9                                               8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
004482CE add_shipcosts__Not_5_9                                               25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
00448426 dx_5_and_9__check_cloak_atk_bit                                      8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
0044842D dx_5_and_9__check_cloak_atk_bit                                      25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
00448663 SetTaskForceAbilities_cloak                                          8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
00448668 SetTaskForceAbilities_cloak                                          25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0044868E SetTaskForceAbilities_cloak                                          8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
00448698 SetTaskForceAbilities_cloak                                          8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
004486A9 SetTaskForceAbilities_cloak                                          8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
00448740 SetTaskForceAbilities_cloak                                          8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
004487A6 SetTaskForceAbilities_cloak                                          8A 58 58                            mov     bl, [eax+58h]   ; shiplist_ext2 ? bx?                                                
004487D3 SetTaskForceAbilities_cloak                                          8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
00448BFA set_engage__colony_TT_evade                                          8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 ? (functions?)                                   
00448BFF set_engage__colony_TT_evade                                          25 FF 00 00 00                      and     eax, 0FFh       ;  shiplist_ext2 ?                                                   
00448C91 shipfunction_edx_present_?_1yes                                      8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc, ship type 0-9                            
00448C96 shipfunction_edx_present_?_1yes                                      25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
00448E76 Move_ships_from_al_due_to_treaty                                     8A 40 52                            mov     al, [eax+52h]   ; eax, shiplist_ext2 +reloc                                          
00448E7B Move_ships_from_al_due_to_treaty                                     25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
00448FE9 systems_stations_list_recipient_al                                   88 44 24 08                         mov     [esp+8], al     ; ax, shiplist_ext2 ?                                                
0044907C systems_stations_list_recipient_al                                   8A 44 24 08                         mov     al, [esp+8]     ; eax, shiplist_ext2 ?                                               
0044996F Combat_groups_via_ship_function                                      8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
00449974 Combat_groups_via_ship_function                                      25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
00449ABA AlienTFInfo_intel                                                    8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
00449AC1 AlienTFInfo_intel                                                    25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
00449D2B intel_steal_destroy_ships                                            8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
00449F7F stolen_ship_from_TF                                                  8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
00449F89 stolen_ship_from_TF                                                  25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
00449FD6 stolen_ship_from_TF                                                  8A C8                               mov     cl, al          ; shiplist_ext2 ? ax cx ?                                            
0044A052 stolen_ship_from_TF                                                  88 C1                               mov     cl, al          ; shiplist_ext2 ? ax cx ?                                            
0044A120 stolen_ship_from_TF                                                  8A 84 24 2C 04 00 00                mov     al, [esp+42Ch]  ; ax, shiplist_ext2 ?                                                
0044A17B stolen_ship_from_TF                                                  8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
0044A2F7 auto_upgrade_station                                                 25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0044A3DB AutoUpgradeShips                                                     8A 84 24 2C 01 00 00                mov     al, [esp+12Ch]  ; eax, shiplist_ext2 old ID                                          
0044A3FE AutoUpgradeShips                                                     8A 84 24 28 01 00 00                mov     al, [esp+128h]  ; eax, shiplist_ext2 new ship ID                                     
0044A45C AutoUpgradeShips                                                     D3 E2                               shl     edx, cl         ; cx, shiplist_ext2 ?                                                
0044A4B0 AutoUpgradeShips                                                     8A 94 24 30 01 00 00                mov     dl, [esp+130h]  ; edx, shiplist_ext2 ?                                               
0044A8EF prepare_GShipList_entry                                              8A 61 58                            mov     ah, [ecx+58h]   ; ax, shiplist_ext2 ?                                                
0044A8F9 prepare_GShipList_entry                                              80 E4 FE                            and     ah, 0FEh        ; ax, shiplist_ext2 ?                                                
0044A8FC prepare_GShipList_entry                                              88 61 58                            mov     [ecx+58h], ah   ; ax, shiplist_ext2 ?                                                
0044B14E load_build_cost__hull                                                88 D0                               mov     al, dl          ; eax,edx shiplist_ext2                                              
0044EEB7 Military_Score_update                                                8A 94 24 DC 01 00 00                mov     dl, [esp+1DCh]  ; dx, shiplist_ext2 ?                                                
0044EF26 Military_Score_update                                                8A 40 2E                            mov     al, [eax+2Eh]   ; ax, shiplist_ext2 +reloc                                           
0044EF2D Military_Score_update                                                25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0044F0AA Military_Score_update                                                8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0044FB42 add_the_Monster                                                      8A 84 24 72 01 00 00                mov     al, [esp+172h]  ; eax, shiplist_ext2                                                 
00454834 NewShipStationResearched                                             8A 42 04                            mov     al, [edx+4]     ; eax, shiplist_ext2                                                 
0045534B                                                                      8A 42 04                            mov     al, [edx+4]     ; eax, shiplist_ext2 ship ID                                         
0045FB8E ship_blg_support__raided_credits                                     8A 94 24 2C 01 00 00                mov     dl, [esp+12Ch]  ; dx, shiplist_ext2 ?                                                
0045FBA1 ship_blg_support__raided_credits                                     8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0045FBF6 ship_blg_support__raided_credits                                     8A 94 24 2C 01 00 00                mov     dl, [esp+12Ch]  ; dx, shiplist_ext2 ?                                                
0045FC0E ship_blg_support__raided_credits                                     8A 41 2E                            mov     al, [ecx+2Eh]   ; eax, shiplist_ext2                                                 
0045FFBB sys_build_ship                                                       8A 45 10                            mov     al, [ebp+10h]   ; eax, shiplist_ext2                                                 
00460286 sys_build_ship                                                       8A C8                               mov     cl, al          ;  shiplist_ext2 ? \/                                                
00462730 Lex_system_results1_SUMMARY_462600                                   8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
00462733 Lex_system_results1_SUMMARY_462600                                   25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
00467453 System__Attack                                                       8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc, ship ID / +28 race ID                    
00467464 System__Attack                                                       25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
00468272 sys_attack_lose_TTs                                                  8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
004683A4 OBs_System_Attack                                                    8A 40 52                            mov     al, [eax+52h]   ; eax, shiplist_ext2                                                 
004683A9 OBs_System_Attack                                                    25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0046866B OBs_System_Attack                                                    8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0046893B                                                                      8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
0046895C                                                                      8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
00468B65 Build_Space_Station                                                  88 D8                               mov     al, bl          ; eax,ebx shiplist_ext2                                              
00468C08 Build_Space_Station                                                  88 D8                               mov     al, bl          ; eax,ebx shiplist_ext2                                              
00468C4B Build_Space_Station                                                  8A 42 52                            mov     al, [edx+52h]   ; eax, shiplist_ext2 ?                                               
00468C5B Build_Space_Station                                                  8A 42 52                            mov     al, [edx+52h]   ; eax, shiplist_ext2 ?                                               
00468CCF Build_Space_Station                                                  88 C1                               mov     cl, al          ; shiplist_ext2 ? \/                                                 
0046924C Terraform                                                            8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
0046924F Terraform                                                            25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
00469407 Scrap_Ship                                                           8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
00469793 RAID_Percentage                                                      8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
00469AD4 new_Colonies                                                         8A 42 52                            mov     al, [edx+52h]   ; eax, shiplist_ext2                                                 
0046B5C9 Ship_Repair                                                          8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
0046B67B Ship_Repair                                                          8A 46 2E                            mov     al, [esi+2Eh]   ; eax, shiplist_ext2                                                 
0046BE65 Black_Hole_46BE08                                                    8A C8                               mov     cl, al          ; ax,cx shiplist_ext2 ? +reloc                                       
0046BE8D Black_Hole_46BE08                                                    8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
0046BE94 Black_Hole_46BE08                                                    25 FF 00 00 00                      and     eax, 0FFh       ;  shiplist_ext2 ?                                                   
0046ED1F Lexicon_Events                                                       8A 41 2E                            mov     al, [ecx+2Eh]   ; eax, shiplist_ext2                                                 
0046F4F0 ship_function_descriptions_Lex                                       88 D0                               mov     al, dl          ; eax,edx shiplist_ext2 /\?                                          
0046F679 read_ship_scan                                                       25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0046F6A9 read_CS_TT_production                                                25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0046F6D9 read_map_range_                                                      25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0046F729 read_map_speed_                                                      25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0046F779 shipfunction_to_eax                                                  25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0046F7A9 read_ship_buildcost                                                  25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0046F9C5 read_shiplist_sst_46F9C0                                             88 C1                               mov     cl, al          ; cx, ax, shiplist_ext2                                              
0046F9F6 read_shiplist_sst_46F9C0                                             88 CA                               mov     dl, cl          ; dx, cx shiplist_ext2                                               
0046FA27 read_shiplist_sst_46F9C0                                             8A C8                               mov     cl, al          ; ax, shiplist_ext2  ?                                               
00476E6F GroupViaShiptype_cloak_info                                          8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
00476E74 GroupViaShiptype_cloak_info                                          25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0047993F AI_OBs_system_attack_Ratio_to_FPU                                    8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
00479944 AI_OBs_system_attack_Ratio_to_FPU                                    25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
00479B81 AI_TT_combat_Ratio_to_FPU                                            8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
00479D30 Sort_AI_shipfunction_values__combat.bin_bug                          8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
00479D46 Sort_AI_shipfunction_values__combat.bin_bug                          8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
0047CA54 ship_map_scan                                                        8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc, shiptype? (scout-tt)                     
0047CA59 ship_map_scan                                                        25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
0047CA81 ship_map_scan                                                        8A 40 34                            mov     al, [eax+34h]   ; ax, shiplist_ext2 +reloc, raceid TF to ship type                   
0047CA86 ship_map_scan                                                        88 84 24 3C 01 00 00                mov     [esp+13Ch], al  ; ax, shiplist_ext2 +reloc                                           
0047CA94 ship_map_scan                                                        66 89 DF                            mov     di, bx          ; shiplist_ext2 ?                                                    
0047CA9D ship_map_scan                                                        8A 94 24 3C 01 00 00                mov     dl, [esp+13Ch]  ; dx, shiplist_ext2, shiptype                                        
0047CAAB ship_map_scan                                                        80 FA 05                            cmp     dl, 5           ; dx, shiplist_ext2                                                  
0047CAB2 ship_map_scan                                                        88 D0                               mov     al, dl          ; ax,dx shiplist_ext2                                                
0047CAD3 ship_map_scan                                                        8A 84 24 3C 01 00 00                mov     al, [esp+13Ch]  ; eax, shiplist_ext2                                                 
0047CAF3 ship_map_scan                                                        8A 84 24 3C 01 00 00                mov     al, [esp+13Ch]  ; eax, shiplist_ext2                                                 
0047CB90 ship_map_scan                                                        8A 40 34                            mov     al, [eax+34h]   ; ax, shiplist_ext2                                                  
0047CB93 ship_map_scan                                                        88 84 24 40 01 00 00                mov     [esp+140h], al  ; ax, shiplist_ext2                                                  
0047CBAD ship_map_scan                                                        66 89 DF                            mov     di, bx          ; shiplist_ext2 ?                                                    
0047CBB7 ship_map_scan                                                        8A A4 24 40 01 00 00                mov     ah, [esp+140h]  ; ?, shiplist_ext2 ?                                                 
0047CBCC ship_map_scan                                                        8A 84 24 40 01 00 00                mov     al, [esp+140h]  ; ax, shiplist_ext2 ?                                                
0047CBF2 ship_map_scan                                                        8A 84 24 40 01 00 00                mov     al, [esp+140h]  ; ax, shiplist_ext2 ?                                                
0047CC10 ship_map_scan                                                        8A 84 24 38 01 00 00                mov     al, [esp+138h]  ; ax, shiplist_ext2 ? al RaceID?                                     
00495759 scout_command_checks                                                 8A 43 52                            mov     al, [ebx+52h]   ; eax, shiplist_ext2                                                 
00495D0E TC_render_weapons_gomtuu_palette_sfx                                 8A 84 24 72 01 00 00                mov     al, [esp+172h]  ; eax, shiplist_ext2 hob for ship?                                   
00495D26 TC_render_weapons_gomtuu_palette_sfx                                                                     loc_495D26:             ; ax, shiplist_ext2 \/                                               
00495D4F TC_render_weapons_gomtuu_palette_sfx                                 B0 00                               mov     al, 0           ; ax, shiplist_ext2 \/                                               
00495DA8 TC_render_weapons_gomtuu_palette_sfx                                 8A 06                               mov     al, [esi]       ; eax, shiplist_ext2 \/ ?                                            
00496072 TC_render_weapons_gomtuu_palette_sfx                                 8A 85 E2 01 00 00                   mov     al, [ebp+1E2h]  ; eax, shiplist_ext2                                                 
00496085 TC_render_weapons_gomtuu_palette_sfx                                                                     loc_496085:             ; ax, shiplist_ext2 \/                                               
004960AE TC_render_weapons_gomtuu_palette_sfx                                 B0 00                               mov     al, 0           ; ax, shiplist_ext2 \/                                               
004960E9 TC_render_weapons_gomtuu_palette_sfx                                                                     loc_4960E9:             ; ax, shiplist_ext2 \/                                               
004961A7 TC_render_weapons_gomtuu_palette_sfx                                 8A 85 06 02 00 00                   mov     al, [ebp+206h]  ; eax, shiplist_ext2                                                 
004961BA TC_render_weapons_gomtuu_palette_sfx                                 8A 06                               mov     al, [esi]       ; ax, shiplist_ext2 \/                                               
004961E3 TC_render_weapons_gomtuu_palette_sfx                                 B0 00                               mov     al, 0           ; ax, shiplist_ext2 \/                                               
0049621E TC_render_weapons_gomtuu_palette_sfx                                 8A 06                               mov     al, [esi]       ; ax, shiplist_ext2 \/                                               
004A2C65 TC_commands_weapon_labels__scout_getGroup                            8A 42 52                            mov     al, [edx+52h]   ; eax, shiplist_ext2                                                 
004A37E1 tactscn_ship_tech_weapon_labels                                      8A 42 2E                            mov     al, [edx+2Eh]   ; eax, shiplist_ext2                                                 
004A6335 TC_orders_player_GUI                                                 8A 84 24 50 01 00 00                mov     al, [esp+150h]  ; eax, shiplist_ext2                                                 
004D123B c_read_shiplist_4D1220                                               88 D0                               mov     al, dl          ; ax,dx shiplist_ext2 +reloc                                         
004D1242 c_read_shiplist_4D1220                                               25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
004D375D sub_4D3720                                                           8A 03                               mov     al, [ebx]       ; eax, shiplist_ext2                                                 
004D40E3                                                                      8A 04 90                            mov     al, [eax+edx*4] ; ax, shiplist_ext2 +reloc                                           
004D40F9                                                                      25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
004D41E3                                                                      8A 04 90                            mov     al, [eax+edx*4] ; ax, shiplist_ext2 +reloc                                           
004D41ED                                                                      25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
004D4201                                                                                                          loop_4D4201:            ; ax, shiplist_ext2 \/ ?                                             
004D431B                                                                                                          loc_4D431B:             ; ax, shiplist_ext2 +reloc                                           
004D4325                                                                      25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
004D433E                                                                                                          loc_4D433E:             ; ax, shiplist_ext2 \/ ?                                             
004D4BD7 ship_build_stats?                                                    88 C8                               mov     al, cl          ; eax, ecx shiplist_ext2                                             
004D6E0C tech_lev_stuff_ships_tga                                             8A 46 2A                            mov     al, [esi+2Ah]   ; eax, shiplist_ext2                                                 
004D6E22 tech_lev_stuff_ships_tga                                             30 DB                               xor     bl, bl          ; ebx, shiplist_ext2 ?                                               
004D6E2B tech_lev_stuff_ships_tga                                             88 D8                               mov     al, bl          ; eax,ebx shiplist_ext2                                              
004D6E37 tech_lev_stuff_ships_tga                                             FE C3                               inc     bl              ; ebx, shiplist_ext2                                                 
004D6E39 tech_lev_stuff_ships_tga                                             80 FB 06                            cmp     bl, 6           ; ebx, shiplist_ext2                                                 
004D6E73 tech_lev_stuff_ships_tga                                             8A 06                               mov     al, [esi]       ; ax, shiplist_ext2 \/ ?                                             
004D736C tech_info_tree_stuff                                                 8A 01                               mov     al, [ecx]       ; 8A > 8B eax, [ecx]; eax, shiplist_ext2                             
004E38D2 Econfilter_Build_Tasks__player                                       8A 40 10                            mov     al, [eax+10h]   ; ax, shiplist_ext2 +reloc                                           
004E38D7 Econfilter_Build_Tasks__player                                       25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ?                                                    
004E727D mapAI_c1_system_Current_Build                                        8A 40 10                            mov     al, [eax+10h]   ; ax, shiplist_ext2 +reloc                                           
004E7282 mapAI_c1_system_Current_Build                                        25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 ? FF FF 00 00?                                       
004E84BF xxx_ships_                                                           8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
004E84C4 xxx_ships_                                                           25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2                                                      
004E8501 xxx_ships_                                                           8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
004E8506 xxx_ships_                                                           25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 FF FF 00 00                                          
004E8D41 show_Station_30_in_TF_column                                         8A 45 2E                            mov     al, [ebp+2Eh]   ; eax, shiplist_ext2 starbase Info                                   
004E9CA1 galaxy_map_economics                                                 8A 84 24 34 0A 00 00                mov     al, [esp+0A34h] ; eax, shiplist_ext2                                                 
004EB263 Ship_stats_Popup_                                                    8A 41 52                            mov     al, [ecx+52h]   ; eax, shiplist_ext2                                                 
004ECD39 Ship_pics_D_station_30_lex_unknown                                   8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
004ECD3E Ship_pics_D_station_30_lex_unknown                                   25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2                                                      
004ED105 show_station_big_tga_stats                                           8A 41 2E                            mov     al, [ecx+2Eh]   ; ax, shiplist_ext2                                                  
004EDEEA Stations_Map_Popup                                                   8A 41 2E                            mov     al, [ecx+2Eh]   ; eax, shiplist_ext2                                                 
004EDF1A Stations_Map_Popup                                                   8A 41 28                            mov     al, [ecx+28h]   ; eax, shiplist_ext2 ?                                               
004EDF5D Stations_Map_Popup                                                   8A 41 28                            mov     al, [ecx+28h]   ; eax, shiplist_ext2 ?                                               
004F299B B_U_Y__UI                                                            8A 46 10                            mov     al, [esi+10h]   ; eax, shiplist_ext2                                                 
004F2F34 build_Queue_display                                                  8A 84 24 38 02 00 00                mov     al, [esp+238h]  ; eax, shiplist_ext2 ?                                               
004F3270 blg_UI_sub_1_?                                                       8A 06                               mov     al, [esi]       ; ax, shiplist_ext2 ? \/                                             
004F32E0 blg_UI_sub_1_?                                                       8A 84 24 F0 02 00 00                mov     al, [esp+2F0h]  ; eax, shiplist_ext2                                                 
004F3DAD Special_Ships_                                                       66 8B 59 04                         mov     bx, [ecx+4]     ; ebx, shiplist_ext2 ?                                               
004F3DB5 Special_Ships_                                                       88 D8                               mov     al, bl          ; eax,ebx shiplist_ext2                                              
004F5134 turns_to_finish_GUI                                                  8A 43 08                            mov     al, [ebx+8]     ; eax, shiplist_ext2                                                 
004F5334 build_ui_solarsys                                                    8A 40 08                            mov     al, [eax+8]     ; ax, shiplist_ext2 +reloc                                           
004F5339 build_ui_solarsys                                                    25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 FF FF                                                
004F534C build_ui_solarsys                                                    8A 41 08                            mov     al, [ecx+8]     ; eax, shiplist_ext2                                                 
004F985B build_order_display_7cases                                           8A 84 24 C8 04 00 00                mov     al, [esp+4C8h]  ; eax, shiplist_ext2                                                 
004FD4F8 check_build_limit_7cases                                             8A 84 24 5C 02 00 00                mov     al, [esp+25Ch]  ; eax, shiplist_ext2                                                 
004FE392 ui_armament_pips_station_30_pic                                      8A 47 52                            mov     al, [edi+52h]   ; eax, shiplist_ext2                                                 
004FE942 ui_armament_ship_pips.tga                                            8A 47 52                            mov     al, [edi+52h]   ; eax, shiplist_ext2                                                 
004FF455 REDEPLOY_Ship_TF_descriptions                                        8A 45 52                            mov     al, [ebp+52h]   ; eax, shiplist_ext2                                                 
005210BC set_TC_ship_info_block_3C8h                                          8A 42 52                            mov     al, [edx+52h]   ; eax, shiplist_ext2                                                 
005218CD set_TC_ship_info_block_3C8h                                          8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
005218D2 set_TC_ship_info_block_3C8h                                          25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 FF FF                                                
0052198D set_TC_ship_info_block_3C8h                                          8A 45 2E                            mov     al, [ebp+2Eh]   ; ax, shiplist_ext2 +reloc                                           
00521998 set_TC_ship_info_block_3C8h                                          25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 FF FF                                                
00521D2A set_TC_ship_info_block_3C8h                                          8A 42 52                            mov     al, [edx+52h]   ; eax, shiplist_ext2                                                 
005223BF set_TC_ship_info_block_3C8h                                          8A 41 2E                            mov     al, [ecx+2Eh]   ; ax, shiplist_ext2 +reloc                                           
005223C4 set_TC_ship_info_block_3C8h                                          25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 FF FF                                                
00528896 shiplist_sst_to_EDX                                                  8A 80 06 02 00 00                   mov     al, [eax+206h]  ; ax, shiplist_ext2 +reloc                                           
0052889C shiplist_sst_to_EDX                                                  25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 FF FF reloc                                          
005288A9 shiplist_sst_to_EDX                                                  8A 80 E2 01 00 00                   mov     al, [eax+1E2h]  ; ax, shiplist_ext2 +reloc                                           
005288AF shiplist_sst_to_EDX                                                  25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 reloc FF FF                                          
0056C49A Retreat_Speed                                                        8A 40 52                            mov     al, [eax+52h]   ; ax, shiplist_ext2 +reloc                                           
0056C49F Retreat_Speed                                                        25 FF 00 00 00                      and     eax, 0FFh       ; shiplist_ext2 FF FF                                                

Several locations in this last section above require relocation due to operand size. I think a mini-subroutine can be written for most of them, some will need to be single jump out and jump back in though. For example mov al, [mem+52h] is followed many times by a mov edx, esp; the mini-subroutine can be called here instead of taking up several unique locations for the same exact duplicated bytes. Most efficient. When mov al, [mem+52h] is preceded by a xor eax, eax it should be safe to use the whole eax in this case > mov eax, [mem+52h], at least when eax gets overwritten later on.

[Flocke]

Several locations in this last section above require relocation due to operand size. I think a mini-subroutine can be written for most of them, some will need to be single jump out and jump back in though. For example mov al, [mem+52h] is followed many times by a mov edx, esp; the mini-subroutine can be called here instead of taking up several unique locations for the same exact duplicated bytes. Most efficient.

That's a very good idea actually! I went through all 155 sub_46F9C0 + 15 sub_46F940 calls yesterday, and already included all of them but a few in upcoming IDA documentation update. It comes down to about 10 different cases to handle, all the rest mostly is repeated code. These include:

1. +52h: Ship_t.shipType
2. +2Eh: Starbase_t.shipType
3. +66h: ShipClass_t.id
4. +04h: ShipTechEntry_t.shipType
5. +10h: ProdQueueItem_t.build.shipType
6. +08h: ?? ProdQueueItem_t.build.structureType / EconomicOrder_t.structureType
7. +2Ah: SceneNode_t.shipType <- new SceneNode_t looks very interesting to mpr btw
8. xor eax, eax; mov al, 0FFh where 0FFh is a 32bit value
9. mov edx, eax; xor eax, eax; mov al, dl; stuff, where edx is a 16bit sub-routine return value
10. xor eax, eax; mov al, dl; where dx is a 16bit sub-routine call param
11. mov al, [ebx] where ebx is a 32bit shipType value array
12. shl eax, 2; lea ecx, [eax+ebp]; xor eax, eax; mov al, [ecx] which looks weird but computes and reads value from 32bit shipType value array offset

Plus all of them I have seen can be fixed in place, most if not all even without adding any helper routines. This investigation now makes me very optimistic that Tethys is right and we can fix all of these without too much effort, rather talking of seconds per repeated fixture.

Not saying that it isn't still alot of work. Already all the asm analysis was. But the work now rather is down to yet undetected code dependencies and exceptions, that I didn't figure yet, like:

Code: Select all

004D40D5         call    UI_TechScrn_TechScrn_4D1A70
004D40DA         mov     edx, ds:dword_5CBA40
004D40E0         mov     edx, [edx+38h]
004D40E3         mov     al, [eax+edx*4]

Eh, what?
Some scene related data structure reading the edx index of some 32bit shipType array?

Code: Select all

004F6066         mov     dx, [eax+ProdQueueItem_t.build.structureId]
004F606A         movsx   eax, dx
--
4F5134         mov     al, byte ptr [ebx+ProdQueueItem_t.build.structureId]

Why does it read the SystemBuildInfo_t.structureId here, not the SystemBuildInfo_t.shipType?
And is it actually reading the SystemBuildInfo_t.structureId or rather the EconomicOrder_t.structureId?

When mov al, [mem+52h] is preceded by a xor eax, eax it should be safe to use the whole eax in this case > mov eax, [mem+52h], at least when eax gets overwritten later on.

Sure. Most importantly all the cases I have seen actually are stored as 16bit short values. It looks rather that the subroutines were declared to only accept 8bit values, which lead to all the 8bit conversion mess.

I didn't went through all your 268 case list yet, but noticed that you included a few false entries that actually read raceId like this one:
44907C systems_stations_list_recipient_al

I will try to finish updating IDA docs today.

P.S. Given all that shipId and shipClass mess, I started to name those ShipClass_t ids "shipType". Not sure about it yet, but ship ids are reserved for actual savegame ship instances, while ship classes already are double-used by object database ship class descriptions. Furthermore the term "type" appears more generic to me for different sets of ship stats of same ship class model. Plus it would be fine to be used for buildings, too.
The only issue I have with it is that ShipType_t shipType = GetShipType(int shipType); does not read well when I rename ShipClass_t

[Tethys]

some of those may have a ? in the comment so they might be not well understood. If any are missing, it would be very few. Thanks for taking a look into this, and it makes me even more optimistic that you are also optimistic

[Tethys]

Flocke, I hadn't even noticed that there were other data (2E) which were also duplicated throughout. However some do use a different register and are sometimes combined with another register [eax+edx+num] in which case, unless there are 2 or more, would be more of a targeted change rather than some handler routine. So it looks like alot can be handled via call and retn, but care should be taken to make sure the right subroutines are being called in the right place

There will be more than 10 mini-subroutines. If there are 2 or more instances it should have a shared handler.

I can begin working on code for a patch, but my time is a bit limited.

[Flocke]

I can begin working on code for a patch, but my time is a bit limited.

Right now, mine sadly is a bit limited, too. The code will become much clearer to investigate with updated IDA DB.
Not sure if I find time for it today though.

[Flocke]

Code: Select all

00479836 81 C5 F4 01 00 00                   add     ebp, 1F4h       ; 500 unused combat.bin entry size

Is this truly unused? Can these bytes be utilized for extension?

By former research and testing it has been found unused. And I can't find any reference but the combat.bin load routine either. That load routine however loops all entries and at asm<47980D> validates that they are not -1. So you will want to nop the validation.

However, keep care to not remove the hard-coded initialization at asm<479841>. That one is still in use for offensive strength calculation.

for reference:

5B58A8: address of loaded combat.bin (seems unused)

I've removed combat.java from the code. It was meant for the combat.bin file, but as thunderchero pointed out it's not being used by botf at all.

I think Gowron tested these files at 1 point, But can not find the post about it. (may have been lost when forum was restored)

I think the files are needed or will cause crash (part of file check) But even if all values are set to (0) it has no effect on game play. The AI control was very messed up since it started as files but seemed to be changed to trek.exe so many files are not used like the combat.bin.

The unused combat.bin is a ship vs ship odds table (pointless unless 1vs1), so instead the AI reads stats like shipfunction, build cost and:

[shiplist.sst +9C] = AI indicator for offensive capability
[shiplist.sst +A0] = AI indicator for defensive capability

[Flocke]

Off topic: why is starname bin with a 125 limit? Is this 125 scans of the map to place names or something?
004B78A4 83 F9 7D cmp ecx, 7Dh ; Compare Two Operands

This is a retry limit for generating the random star name index.

Each time it is looped, the random number is divided by the actual star name count to compute the edx remainder.
The remainder then is used to index the star names. And at 0x14 the entry is checked for the name length.
Only when that is zero, the random compution is repeated and the counter keeps incrementing.

While 0x14 by default is set to the name length, it might also be used to indicate what names are already in use. But I didn't do any debugging to check on it.

Taking a look at starname.bin. It looks to be split into 10 sections, with star names first sorted by length and then alphabetically:
000-001: 3 letters: Exo, Kea
002-016: 4 letters: Brax - Ruah
017-067: 5 letters: Alpha - Zayra
068-156: 6 letters: Altair - Yadera
157-208: 7 letters: Arkaria - Zytchin
209-246: 8 letters: Andevian - Xanthras
247-255: 9 letters: Adelphous - Tau Cygna
256-273: 10 letters: Berengaria - Zeta Alpha
274-284: 11 letters: Deinonychus - Theta Cygni
285-296: 12 letters: Alpha Cygnus - Ultima Thule

For each of the entries, at 0x14 the size of the string is stored as length + 0-termination character.
In AFC Vanilla install it has been defaulted to 0x15, which is wrong, because the max valid length is limited to 0x14. This however likely has no effect, because the string is still 0-terminated.

My original BOTF CD lists correct name length.

[Spocks-cuddly-tribble]

Yes, combat.bin is loaded but not used -> you can remove load code to prevent crash before removing file from stbof.res

While 0x14 by default is set to the name length, it might also be used to indicate what names are already in use. But I didn't do any debugging to check on it.


For each of the entries, at 0x14 the size of the string is stored as length + 0-termination character.
In AFC Vanilla install it has been defaulted to 0x15, which is wrong, because the max valid length is limited to 0x14. This however likely has no effect, because the string is still 0-terminated.

My original BOTF CD lists correct name length.

Yes, starname.bin entry+14h mustn't be 0 for the used names marker, but any hex value other than 0 does the same. So vanilla or AFC value doesn't matter.

[Flocke]

P.S. Given all that shipId and shipClass mess, I started to name those ShipClass_t ids "shipType". Not sure about it yet, but ship ids are reserved for actual savegame ship instances, while ship classes already are double-used by object database ship class descriptions. Furthermore the term "type" appears more generic to me for different sets of ship stats of same ship class model. Plus it would be fine to be used for buildings, too.
The only issue I have with it is that ShipType_t shipType = GetShipType(int shipType); does not read well when I rename ShipClass_t

I think this issue bugged me already from the start when I implemented UE savegame editing!
I remember I once already started some discussion on it and SCT you pointed me at trek.exe code, but I can't find any post on it. In trek.exe I however found the Order_t logging routine sub<455988>, which you probably reffered to.

By sub<455988> I'd have to rename "shipRole" + "shipFunction" back to "shipType", "shipType" to "shipClassId" and "buildingType" to "structureId".

Further ship role = ship type references:
asm<40CDCD> "shipCounts[item->shipType] >= 1"
asm<42B999> "Invalid ship type encountered"

Further ship type = ship class references:
asm<46FA75> "Need to open ship class database before ship description"
asm<46F9D7> "shipClassMem is NULL\n"


What I however dislike on it is:

1. That each savegame building and energy structure should have a unique id to be identified.
   Even when BOTF doesn't assign any IDs, ids should be reserved for actual object instances.
   And maybe I'd add a mapping some time for identification.
2. stbof.res building and ship entries should have a consistent naming convention.
3. Ship class names are displayed ingame in the object database, still they have multiple entries for the upgrades, so the same ship class name identifier becomes ambiguous.

I however think it is better to remain trek.exe consistent and therefore I tend to rename all these entries accordingly.
If then I need another building ID, I'll find a different name like "instanceId".
And for the ship classes one still can argue they indeed are the same class but just different versions, therefore in trek.exe it is named "ClassId" and not simply "Class" *ha ha - ironic laugh*.

Any thoughts?

----
Edit: Moved OrderInfo findings to viewtopic.php?p=64927#p64927

[Spocks-cuddly-tribble]

for the ship classes one still can argue they indeed are the same class but just different versions, therefore in trek.exe it is named "ClassId" and not simply "Class" *ha ha - ironic laugh*.

Any thoughts?

function = type (e.g. colony, TT, outpost) -> makes sense -> so source label type is fine

'Class' is a mess e.g. Defiant, Galor or Galaxy might have different versions (shiplist.sst IDs)
-> shipClassDatabase (shiplist.sst) -> AI fleetbuildup and upgrade bugs since they failed to anticipate this concept bias

shipID (alone) -> also a mess -> GshipList OR shiplist.sst MUST be obvious
-> source code means savegame items (e.g. GshipList), but modder mean shiplist.sst items

Moved OrderInfo findings to viewtopic.php?p=64927#p64927

0x38-0x3B action: again some diplomatic action type
possibly related to the target effects

ORDER_DIPLOMACY_typeId_5 +38h -> treatyType -> same as treaty+30h -> sub_45C6F8 used for new treaties

[Flocke]

shipID (alone) -> also a mess -> GshipList OR shiplist.sst MUST be obvious
-> source code means savegame items (e.g. GshipList), but modder mean shiplist.sst items

That was main reason I renamed shipId to shipType for UE savegame editing.
They could just not have same names when added to same Java ship class.

In trek.exe the shiplist.sst IDs are named "ClassId". But it is not surprising that when edifice.bst buildings have an entry ID, that ppl anticipate shiplist.sst items to have one, too! That is why (2.) I'd prefer a consistent naming convention.

But now, by trek.exe the buildings are actually structures and have both the edifice.bst structureId AND a structureType, which I guess stands for the food/industry/energy/intel/research type. And Ships have a shipType, which stands for the ship function or role.
So type would be consistent and looks fine to me as well.

And while I would be fine to rename buildingId and shipClassId to something else than a 'type', I would want to keep it consistent at least for all future documentation and I am not sure what name to use.

To cause even more confusion, at asm<41874E> the shipType (function/role) is mapped to text values and printed with a "design" label...

ORDER_DIPLOMACY_typeId_5 +38h -> treatyType -> same as treaty+30h -> sub_45C6F8 used for new treaties

Thanks! I updated documentation on this.
Edit: By asm<45C7B1> the diplomatic orders actually turned out to fully contain the treaty data structure!
Edit2: By that subroutine, ResultHeader + 0x0C-0x0D is a notification mask of known empires for peace and alliance treaties, c.f. asm<45C7F5,45C80E,45C875,45C9CC>. I updated the result documentation accordingly.

[Spocks-cuddly-tribble]

By that subroutine, ResultHeader + 0x0C-0x0D is a notification mask of known empires for peace and alliance treaties

There is still some GUI code glitches e.g. you can propose war pacts vs unknown empires and when proposing empire affiliation text changes to friendship.

Hotfixed the 'move stranded fleets due to ended treaty fix' by not ending old treaty when signing alliance in sub 45C6F8. Issue was when this code terminates affiliations, my code determines loss of shared range and wrongfully moves ships before alliance replaces the current affiliation treaty.
I hope this causes no issues if the pre-alliance treaty was time restricted and/or coupled with credits per turn.