editing zoom in view

[Spocks-cuddly-tribble]

right shift stopped and Full view is shifted full left

Yes, but I don't want this, so a dynamic fix is needed.

You can try to change this with same values used in default fix, but I doubt it works for all switch modes:

Code: Select all

004DBEFE           mov   [esp+54h], eax                    ; width grid
004DBF02           mov   [esp+34h], eax                    ; width grid

004DBF12           mov   ebp, eax                          ; height grid
004DBF14           mov   [esp+38h], eax                    ; height grid

Or based or your test:

Code: Select all

4DC123           add   esp, 5Ch -> jmp 4DC102

Found the pictures I was looking for (race selection for MP team games). Needless to say we're not going to use that "art"work...

empire_selection.png

[thunderchero]

right shift stopped and Full view is shifted full left

Yes, but I don't want this

yes we do want it, if we want full view to scroll
and yes it does scroll now. (still has issues though, when zoom to full it will always go to top left so it does not re-center on selected system)
but if full shifted full left it give more room for art work on right?
Edit I tried adding image and it failed due to map conflicts

You can try to change this with same values used in default fix, but I doubt it works for all switch modes:

Code: Select all

004DBEFE           mov   [esp+54h], eax                    ; width grid
004DBF02           mov   [esp+34h], eax                    ; width grid

004DBF12           mov   ebp, eax                          ; height grid
004DBF14           mov   [esp+38h], eax                    ; height grid

crash to desktop

Or based or your test:

Code: Select all

4DC123           add   esp, 5Ch -> jmp 4DC102

no change noticed

EDIT;
on a side note clicking on map or with mudd F11 will clear unwanted map effect
also I have been experiencing a lot of readrace.c on galaxy generation. I think the min empire distance needs to be lower (I notice this more since I have movies "OFF")

[Spocks-cuddly-tribble]

yes we do want it, if we want full view to scroll
and yes it does scroll now. (still has issues though, when zoom to full it will always go to top left so it does not re-center on selected system)

It's not that hard, we both are just the least qualified AFC modder to analyze this type of rendering code.
But each time we look at it we understand a bit more. I might have misinterpreted the special switch cases (messy code setup).

EDIT: For faster testing I'll install vanilla widescreen (HD, not full HD) with larger galaxy (4:3 grid). Do we have a patch for this?

but if full shifted full left it give more room for art work on right?
Edit I tried adding image and it failed due to map conflicts

Just centering zoom-out with no extra artwork would be fine. But feel free to add above "artwork" to one of your mods' galaxy screen....

also I have been experiencing a lot of readrace.c on galaxy generation. I think the min empire distance needs to be lower (I notice this more since I have movies "OFF")

Yes, funny thing. I recall with first UDM large you advised user to allow movie to run half way to prevent issues. I never did this with any large map mod and had no issues.

BUT when quick starting/testing MANY galaxy generations (different empires/settings) in a row (plus quick movie skip) I got occasional the same issue.

The 'regular' ECM large tests/games never showed any issue. So I'd rather keep current 'patch increased' min distances with rare issues.

It's not only about empire placement, but also about minor races (bugged minor placement code tries to re-add the empires ).

But I'll look into using the minor table fix for ECM.

[thunderchero]

EDIT: For faster testing I'll install vanilla widescreen (HD, not full HD) with larger galaxy (4:3 grid). Do we have a patch for this?

the below trek.exe (for 1366 x 768 english) has already been patched with
AIFleetBuildupFix.patch
ECM_Larger_Maps_With_AI_Tweaks.patch
Large_map_general_settings.patch
plus I have already ran QD's bof_res_patch-130820.exe to adjust sector pixel sizes and alignment multipliers for different area size
no special correction patches have been added (this is my backup for editing)

trek.zip

we both are just the least qualified AFC modder to analyze this type of rendering code.
But each time we look at it we understand a bit more.

sorry to say I am completely lost right now.

[Spocks-cuddly-tribble]

the below trek.exe (for 1366 x 768 english) has already been patched

Windows 10 gives me some hardcore nerd complaint and deletes the exe plus shortcut when trying to launch game (exe says ECM, not vanilla) via shortcut....

Could you link your removed general large maps setting patch again (4:3 grid for all res versions IIRC)?

Meanwhile I'll reinstall vanilla & ECM (again).

[thunderchero]

the below trek.exe (for 1366 x 768 english) has already been patched

Windows 10 gives me some hardcore nerd complaint and deletes the exe plus shortcut when trying to launch game (exe says ECM, not vanilla) via shortcut....

Could you link your removed general large maps setting patch again (4:3 grid for all res versions IIRC)?

Meanwhile I'll reinstall vanilla & ECM (again).

here is complete patch file from fresh ECM english 1366 to my test version.

Code: Select all

NAME: ECM Larger Maps test
DESC: Larger Maps for ECM by thunderchero
DESC: Improves single player experience with larger maps via extra AI tweaks.
AUTHOR: thunderchero / SCT
URL: 

>> 0x0001c450 1e
>> 0x0003ccb8 08
>> 0x0003cccd 0f
>> 0x0003ccd4 0a
>> 0x0003cce8 10
>> 0x0003ccfd 1e
>> 0x0003cd04 14
>> 0x0003ceba 10
>> 0x0003ceee 1e
>> 0x0003cef5 14
>> 0x0004dcb1 31 f6 01 eb e8 e6 83 0b 00 66 89 c6
>> 0x0004dcd3 f3
>> 0x0004dcda 31 31 f6 66 8b 31
>> 0x0004dce3 77
>> 0x0004dce7 44 59
>> 0x0004dd2c 81
>> 0x0004dd2e f4 01 00 00
>> 0x0004dd4b 05 f4 01 00 00
>> 0x0004ddf1 81 c1 84 2b 5a 00
>> 0x0004ddf8 a4 82 0b 00
>> 0x0004de01 d8 09 00
>> 0x0004de25 7c 5e 0c 66 8b 74 59 0c
>> 0x0004e9e3 08
>> 0x0004e9fa 10
>> 0x0004eb0e 0a
>> 0x0004eb18 0f
>> 0x0004eb24 14
>> 0x0004eb2e 1e
>> 0x00050142 89 c1
>> 0x00051dd3 e9 2b
>> 0x00051deb 00
>> 0x00051dee 00 00
>> 0x00051e14 89 c3 8d 04 95 00 00 00
>> 0x00051e1d b9 e8 17 5b 00 01 d0 31 f6 c1 e0 02 66 89 de
>> 0x00051e2d c1 8d 04 b5 00 00
>> 0x00051e34 00 29 f0 c1 e0 02 89 c6 c1 e0 03 8b 3d 50 18 5b 00 01 f0 01 c7 8d 04 d5 00 00 00
>> 0x00051e50 01 d0 c1 e0 02 01 d0 c1 e0 02 89 c2 c1 e0 02 29 d0 05 98 1a 5b 00 05 98 00 00 00 89 44 24 70 8b 40 14 89 44 24 6c 30 e4 89 4c 24 68
>> 0x00052054 68
>> 0x00066854 40 52 89 e2 b9 48 00 00 00 8d bc 24 20 01 00 00 25 ff
>> 0x00066867 00 00 89 e6 e8 50 85 00 00 f3 a5 8b 84 24 ac 01
>> 0x00066878 00 0f af 84 24 a8 01 00 00 0f af 84 24 a4 01 00 00 8b b4 24 b0 03 00 00 39 f0 7d 10 89 f2 29 c2 89 94 24 b0 03 00 00 e9 27 fc ff ff 89 c1 31 c0
>> 0x000668ad 89 84 24 b0 03 00 00 b8 84 a8 57 00 29 f1
>> 0x00068673 89 c8 c1 e1 02 29 c1 c1 e1 03 01 c1 89 e8 31 d2 31 e8
>> 0x00068686 8b 55 3a 66 8b 45 3c 29 c2 c1 e1 02 89 d0 39 d1 76 02 89 d1 8b 04 24 89 cb 31 d2 8b 40 0a 66 8b 54 24 04 c1 f8 10
>> 0x000ae47e 32
>> 0x000ae483 64
>> 0x000ae4a1 04
>> 0x000ae4b1 14
>> 0x000ae525 28
>> 0x000ae52a 50
>> 0x000ae53f 9a 99 19
>> 0x000ae544 04
>> 0x000ae554 10
>> 0x000ae563 03
>> 0x000ae568 14
>> 0x000ae572 1c
>> 0x000ae581 10
>> 0x000ae590 04
>> 0x000ae595 08
>> 0x000ae5b2 04
>> 0x000ae5c6 05
>> 0x000ae5cb 0a
>> 0x000ae5d0 0d
>> 0x000ae5e6 03
>> 0x000ae5f0 10
>> 0x000ae5ff 04
>> 0x000ae604 19
>> 0x000ae60e 21
>> 0x000ae623 05
>> 0x000ae628 0a
>> 0x000ae643 04
>> 0x000ae656 06
>> 0x000ae65b 0a
>> 0x000ae660 0d
>> 0x000ae665 04
>> 0x000ae6b3 4b
>> 0x000ae6b8 96 00
>> 0x000ae6d2 06
>> 0x000ae6d7 3c
>> 0x000ae6dc 44
>> 0x000ae6e6 1e
>> 0x000ae6f5 06
>> 0x000ae706 06
>> 0x000ae70b 0f
>> 0x000ae728 06
>> 0x000ae73c 07
>> 0x000ae741 0e
>> 0x000ae759 06
>> 0x000ae75e 0e
>> 0x000af8ab 30
>> 0x000afa25 46 00
>> 0x000afa3b 64 00
>> 0x000afa49 e6 00
>> 0x000afa94 e6 00
>> 0x000b15cb 10
>> 0x000b15d2 08
>> 0x000b160d 14
>> 0x000b1614 0a
>> 0x000b163f 1e
>> 0x000b1646 0f
>> 0x000b16de 03
>> 0x000b16e5 05
>> 0x000b16ec 08
>> 0x000b16f3 08
>> 0x000b16fa 0f
>> 0x000b1701 15
>> 0x000b1708 0c
>> 0x000b170f 18
>> 0x000b1716 1e
>> 0x000b1843 31 c0 31 d2 83 c1 04 8a 90 2c 2b 5a 00 40 89 54 0c 10 83 f8 05 7c eb 8d 54 24 14 89 d8 e8 cb 58 00 00 30 e4 88 64 24 2c 55 8b 54 24 2c 52 31 d2 8a 54 24 34 89 f9 89 f0 8b 5c 94 08 e8 4c 00 00 00 8a 54 24 2c fe c2 88 54 24 2c 80 fa 05 72 d8
>> 0x000b5fd4 14
>> 0x000b5fe9 10
>> 0x000b5ff0 1e
>> 0x000b608f 14
>> 0x000b60a1 10
>> 0x000b60a8 1e
>> 0x000b6118 1e
>> 0x000b611d 0f
>> 0x000b615c 10
>> 0x000b6161 08
>> 0x000b6168 14
>> 0x000b616d 0a
>> 0x000b61c9 10
>> 0x000b61e1 08
>> 0x000b629f 14
>> 0x000b62a9 1e
>> 0x000b62b5 0a
>> 0x000b62bf 0f
>> 0x000b6451 14
>> 0x000b6456 0a
>> 0x000b6571 10
>> 0x000b6576 08
>> 0x000b6591 1e
>> 0x000b6596 0f
>> 0x000b7130 53 51 56 57 55 83 ec 1c 89 c7 89 d5 8d 5c 24 14 8d 54 24 18 b8 74 fc 57 00 e8 b2 d4 05
>> 0x000b714e 89 fb 89 ea 83 c5 14 b9 14
>> 0x000b715a 8b 74 24 18 89 e7 57 89 c8 c1 e9 02 f2 a5 8a c8 80 e1 03 f2 a4 5f 8b 3a 83 c3 04 8b 3c bc 83 c2 04 89 7b fc 39 ea 75 d3 8b 44 24 18 e8 a5 d3 05
>> 0x000b718b 83 c4 1c 5d 5f 5e 59 5b c3
>> 0x000b7198 00
>> 0x000b719c 00
>> 0x000d9c3e 53 41
>> 0x000d9c4b 29 41
>> 0x000d9c56 00 00 e0
>> 0x000d9c60 42
>> 0x000d9c6a 35
>> 0x000d9c74 23
>> 0x000da42d 42
>> 0x000da437 35
>> 0x000da441 23
>> 0x000da683 42
>> 0x000da68d 35
>> 0x000da697 23
>> 0x000da940 42
>> 0x000da94a 35
>> 0x000da954 23
>> 0x000da97c 53 41
>> 0x000da98c 29 41
>> 0x000da99a 00 00 e0
>> 0x000daf66 42
>> 0x000daf6c 35
>> 0x000daf72 23
>> 0x000dafd5 42
>> 0x000dafdc 35
>> 0x000dafe3 23
>> 0x000db08d 42
>> 0x000db094 35
>> 0x000db09b 23
>> 0x000db187 53 41
>> 0x000db191 29 41
>> 0x000db19c 00 00 e0
>> 0x000db532 53 41
>> 0x000db53f 29 41
>> 0x000db54a 00 00 e0
>> 0x000db8a8 42
>> 0x000db8b2 35
>> 0x000db8bc 23
>> 0x000dbcb5 42
>> 0x000dbcbf 35
>> 0x000dbcc9 23
>> 0x0011092d 1b
>> 0x0017d538 ab aa aa aa aa aa ea
>> 0x0017d5a0 fc b3 3d
>> 0x0017d5a6 12
>> 0x0017d5a8 50 45 52
>> 0x0017d5ae 09
>> 0x0017d5b0 50 45 52
>> 0x0017d5b6 f9 3f
>> 0x0017d668 9a 99 99 99 99 99 c9


<< 0x0001c450 34
<< 0x0003ccb8 16
<< 0x0003cccd 27
<< 0x0003ccd4 1e
<< 0x0003cce8 1e
<< 0x0003ccfd 34
<< 0x0003cd04 28
<< 0x0003ceba 1e
<< 0x0003ceee 34
<< 0x0003cef5 28
<< 0x0004dcb1 03 dd e8 e8 83 0b 00 c1 e8 03 8b f0
<< 0x0004dcd3 cb
<< 0x0004dcda 29 0f b7 4d 00 90
<< 0x0004dce3 4f
<< 0x0004dce7 74 5d
<< 0x0004dd2c 83
<< 0x0004dd2e 02 90 90 90
<< 0x0004dd4b 83 c0 02 90 90
<< 0x0004ddf1 e8 aa 82 0b 00 c1
<< 0x0004ddf8 03 90 90 90
<< 0x0004de01 5c 35 5a
<< 0x0004de25 7e 02 66 8b 71 02 90 90
<< 0x0004e9e3 16
<< 0x0004e9fa 1e
<< 0x0004eb0e 1e
<< 0x0004eb18 27
<< 0x0004eb24 28
<< 0x0004eb2e 34
<< 0x00050142 eb 31
<< 0x00051dd3 49 2c
<< 0x00051deb 0f
<< 0x00051dee 0a 05
<< 0x00051e14 6b f8 6c 03 3d 50 18 5b
<< 0x00051e1d 6b c2 14 05 e8 17 5b 00 89 44 24 68 69 c2 bc
<< 0x00051e2d 00 00 05 30 1b 5b
<< 0x00051e34 89 44 24 70 8b 40 14 8a ca b5 01 d2 e5 84 2d 28 2b 5a 00 75 2d 0f b6 9a eb 29 45
<< 0x00051e50 8a 15 44 2b 5a 00 4a 6b d2 05 03 da 0f af d8 8b cb 83 c1 03 c1 e9 02 03 d9 c1 e9 03 03 d9 83 c3 60 c1 eb 07 03 c3 89 44 24 6c 32 e4
<< 0x00052054 c8
<< 0x00066854 48 28 8a 40 52 8b d4 e8 60 85 00 00 8d 94 24 84 00 00
<< 0x00066867 8b 02 0f af 42 04 0f af 42 08 8d bc 24 b0 03 00
<< 0x00066878 3b 07 7f 07 29 07 e9 48 fc ff ff 2b 07 89 37 b5 01 d2 e5 84 2d 28 2b 5a 00 8b c8 75 0e c1 e9 01 8b 47 48 80 78 04 01 75 02 33 c9 b8 84 a8 57 00
<< 0x000668ad 90 90 90 90 90 90 90 90 90 90 90 90 90 90
<< 0x00068673 6b d9 64 8a 4f 08 b5 01 d2 e5 84 2d 28 2b 5a 00 75 0c
<< 0x00068686 a1 44 2b 5a 00 90 0f af d8 90 90 0f b7 45 3a 66 2b 45 3c 3b d8 76 02 8b d8 8b 04 24 0f b7 54 24 04 0f b7 40 0c 90
<< 0x000ae47e 96
<< 0x000ae483 c8
<< 0x000ae4a1 0a
<< 0x000ae4b1 28
<< 0x000ae525 6e
<< 0x000ae52a 96
<< 0x000ae53f 00 00 40
<< 0x000ae544 07
<< 0x000ae554 1e
<< 0x000ae563 07
<< 0x000ae568 4a
<< 0x000ae572 50
<< 0x000ae581 1e
<< 0x000ae590 07
<< 0x000ae595 16
<< 0x000ae5b2 07
<< 0x000ae5c6 07
<< 0x000ae5cb 26
<< 0x000ae5d0 26
<< 0x000ae5e6 08
<< 0x000ae5f0 1e
<< 0x000ae5ff 0a
<< 0x000ae604 5a
<< 0x000ae60e 6b
<< 0x000ae623 10
<< 0x000ae628 1e
<< 0x000ae643 0a
<< 0x000ae656 0a
<< 0x000ae65b 32
<< 0x000ae660 32
<< 0x000ae665 0a
<< 0x000ae6b3 c3
<< 0x000ae6b8 04 01
<< 0x000ae6d2 0d
<< 0x000ae6d7 82
<< 0x000ae6dc 8a
<< 0x000ae6e6 34
<< 0x000ae6f5 0d
<< 0x000ae706 0d
<< 0x000ae70b 27
<< 0x000ae728 0d
<< 0x000ae73c 0a
<< 0x000ae741 63
<< 0x000ae759 0d
<< 0x000ae75e 63
<< 0x000af8ab a5
<< 0x000afa25 2c 01
<< 0x000afa3b fb 01
<< 0x000afa49 ec 07
<< 0x000afa94 ec 07
<< 0x000b15cb 1e
<< 0x000b15d2 16
<< 0x000b160d 28
<< 0x000b1614 1e
<< 0x000b163f 34
<< 0x000b1646 27
<< 0x000b16de 15
<< 0x000b16e5 1a
<< 0x000b16ec 1f
<< 0x000b16f3 15
<< 0x000b16fa 1a
<< 0x000b1701 1f
<< 0x000b1708 15
<< 0x000b170f 1a
<< 0x000b1716 1f
<< 0x000b1843 0f b6 91 2c 2b 5a 00 6b c1 14 80 3d 44 2b 5a 00 04 7c 10 b5 01 d2 e5 84 2d 28 2b 5a 00 b5 00 75 02 b0 64 8b 9c 90 28 7d 4b 00 8a d1 8b c6 51 8b cf 55 ff 74 24 30 e8 52 00 00 00 59 80 c1 01 80 f9 05 72 bc 90 90 90 90 90 90 90 90 90 90 90 90
<< 0x000b5fd4 28
<< 0x000b5fe9 1e
<< 0x000b5ff0 34
<< 0x000b608f 28
<< 0x000b60a1 1e
<< 0x000b60a8 34
<< 0x000b6118 34
<< 0x000b611d 27
<< 0x000b615c 1e
<< 0x000b6161 16
<< 0x000b6168 28
<< 0x000b616d 1e
<< 0x000b61c9 1e
<< 0x000b61e1 16
<< 0x000b629f 28
<< 0x000b62a9 34
<< 0x000b62b5 1e
<< 0x000b62bf 27
<< 0x000b6451 28
<< 0x000b6456 1e
<< 0x000b6571 1e
<< 0x000b6576 16
<< 0x000b6591 34
<< 0x000b6596 27
<< 0x000b7130 00 00 00 00 01 00 00 00 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 02
<< 0x000b714e 00 00 00 00 00 00 00 00 00
<< 0x000b715a 00 00 01 00 00 00 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 02 00
<< 0x000b718b 00 00 00 00 00 00 00 00 00
<< 0x000b7198 02
<< 0x000b719c 04
<< 0x000d9c3e 93 40
<< 0x000d9c4b 59 40
<< 0x000d9c56 66 66 26
<< 0x000d9c60 17
<< 0x000d9c6a 11
<< 0x000d9c74 0d
<< 0x000da42d 17
<< 0x000da437 11
<< 0x000da441 0d
<< 0x000da683 17
<< 0x000da68d 11
<< 0x000da697 0d
<< 0x000da940 17
<< 0x000da94a 11
<< 0x000da954 0d
<< 0x000da97c 93 40
<< 0x000da98c 59 40
<< 0x000da99a 66 66 26
<< 0x000daf66 17
<< 0x000daf6c 11
<< 0x000daf72 0d
<< 0x000dafd5 17
<< 0x000dafdc 11
<< 0x000dafe3 0d
<< 0x000db08d 17
<< 0x000db094 11
<< 0x000db09b 0d
<< 0x000db187 93 40
<< 0x000db191 59 40
<< 0x000db19c 66 66 26
<< 0x000db532 93 40
<< 0x000db53f 59 40
<< 0x000db54a 66 66 26
<< 0x000db8a8 17
<< 0x000db8b2 11
<< 0x000db8bc 0d
<< 0x000dbcb5 17
<< 0x000dbcbf 11
<< 0x000dbcc9 0d
<< 0x0011092d 7f
<< 0x0017d538 66 66 66 66 66 66 ee
<< 0x0017d5a0 d2 21 33
<< 0x0017d5a6 22
<< 0x0017d5a8 18 2d 44
<< 0x0017d5ae 19
<< 0x0017d5b0 18 2d 44
<< 0x0017d5b6 09 40
<< 0x0017d668 ba 49 0c 02 2b 87 b6

[Spocks-cuddly-tribble]

Same issue. Windows complains about missing rights and deletes exe & shortcut without notice (not restorable).

I'm out of time right now, but next time will try to launch exe with admin rights (never needed this before).

Did you change any registry settings in trek.exe patch code?

My default directory is c:\botf\ecm (or vanilla for vanilla).

[thunderchero]

Same issue. Windows complains about missing rights and deletes exe & shortcut without notice (not restorable).

I'm out of time right now, but next time will try to launch exe with admin rights (never needed this before).

Did you change any registry settings in trek.exe patch code?

My default directory is c:\botf\ecm (or vanilla for vanilla).

windows 10 sucks....

It might help to run as admin, but also check if it is "blocked" by right click trek.exe and select properties before attempting running

does this happen before you patch it?

trek.exe use registry path not install path
HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microprose\Star Trek: ECM
and
HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\DirectPlay\Applications\BOTF:ECM5.0

Large_map_general_settings.patch

[Spocks-cuddly-tribble]

does this happen before you patch it?

No, AIO beta vanilla & ECM 1366 x 768 english have no issues.
It starts after your above exe and/or patch (same issue each).

Large_map_general_settings.patch

Works testing with vanilla, but looks funny and is crashy (unlike 4:3 large maps in 800x600 res):

Screenshot (118).png

[thunderchero]

Works testing with vanilla, but looks funny and is crashy (unlike 4:3 large maps in 800x600 res):

you still need to apply QD's bof_res_patch.exe
to apply first you need to extract all files from stbof.res to a folder so QD's bof_res_patch can read every wdf to get values.
run bof_res_patch
when app loads browse for trek.exe you want to edit
next browse for folder you extracted stbof.res
enter dimensions
and patch

bof_res_patch.zip

but with the issues you are having with patches and replacement trek I doubt if it will work.

[thunderchero]

Works testing with vanilla, but looks funny and is crashy (unlike 4:3 large maps in 800x600 res):

I also have noticed strange behavior on beta6, I have re-compiled and re-uploaded Beta6a

All in one 2.0.1 beta 6a

EDIT; beta 6a in my tests is stable, no idea what issue was. bad compile or compression would be my guess no files were changed.

[Spocks-cuddly-tribble]

EDIT; beta 6a in my tests is stable, no idea what issue was. bad compile or compression would be my guess no files were changed.

No more unexpected crashes with vanilla 1366 Your above exe/patch still same verification error, abort prevented deleting shortcut.

also I have been experiencing a lot of readrace.c on galaxy generation. I think the min empire distance needs to be lower (I notice this more since I have movies "OFF")

MinEmpireDistance issues should cause galaxy hang-ups (exit/freeze after long loop without crash log).

@ File: ..\..\source\universe\readrace.c, Line: 257, 0 (loc_4AEDE4)

First report 2 months after Gowron posted minor table codes. Dafeds confirmed the issue and reduced the max numbers in the table to 30.

You should re-set max number in all mods and map patches from 31 to 30 and and test with this patch: viewtopic.php?p=57430#p57430

Plus this patch: (can you get 30 minors with no more crashes?)

Code: Select all

NAME: Minor Placement - Random Race IDs Fix
DESC: Might help with: "File: ..\..\source\universe\readrace.c, Line: 257, 0" crashes.
AUTHOR: Spocks-cuddly-tribble
URL: https://www.armadafleetcommand.com/onscreen/botf/viewtopic.php?p=57464#p57464

>> 0xB12D7 23
<< 0xB12D7 1E

>> 0xB12E0 89 D0 31 D2 66 89 C2
<< 0xB12E0 83 C2 05 8B C2 90 90


#004B1ED6     BB 1E000000    MOV EBX,1E  // random range 30

#004B1EE0     83C2 05        ADD EDX,5   // IDs 0-29 + 5 (skip empire IDs)
#004B1EE3     8BC2           MOV EAX,EDX
#004B1EE5     90             NOP
#004B1EE6     90             NOP

(still has issues though, when zoom to full it will always go to top left so it does not re-center on selected system)

Here is fixed option for full view shifted up/left with zoom-in centered on selected object (rendering issue not solved):

Code: Select all

004DD228     B9 3B040000    MOV ECX,43B
004DD22D     BE 26020000    MOV ESI,226
004DD232     90             NOP
004DD233     90             NOP
004DD234     90             NOP
004DD235     90             NOP
004DD236     90             NOP
004DD237     90             NOP
004DD238     90             NOP
004DD239     90             NOP
004DD23A     90             NOP
004DD23B     90             NOP

004DBF66    0F85 96010000   JNZ 004DC102

[thunderchero]

Will look into max minor patch/fix

(rendering issue not solved)

as for using background image for map area all attempts failed

options to clear rending issue
1. "F1" key (best option does not effect when in zoom)
2. "n" key (twice to restore system name)
3. clicking on "MAP" on screen button gets focus

strange only the "O" key on keyboard has issues, have you found that sub yet?

but don't know if you can code simulated key usage?

EDIT;
I doubt if it will help but tried to find code related to "F" buttons here are locations I found
F1 401BAD
F2 401BE0
F3 401CA8
F4 4019B7
F5 4019E5
F7 401AC3
pause/break 401B1A

I stopped when I found F1, but could test other if someone wants info. some QD already marked.

[Spocks-cuddly-tribble]

Optimised/shortened dynamic patch (dimensions read from wdf, works for all resolutions):

Code: Select all

NAME: Dynamic Widescreen Zoom-In for Any Galaxy Grid
DESC: Improves e.g. 4:3 galaxy grids (better for AI and game balance) in widescreen GUIs.
AUTHOR: Spocks-cuddly-tribble/thunderchero
URL: https://www.armadafleetcommand.com/onscreen/botf/viewtopic.php?p=57467#p57467

>> 0x000d7f8e 59 c3
>> 0xDB4FD E8 9E 19 06 00
>> 0x000dc60c 8b 45 08

<< 0x000d7f8e eb 0f
<< 0xDB4FD EB 0A 90 90 90
<< 0x000dc60c eb 68 90

#004D8B8E   EB 0F          JMP SHORT 4D8B9F  // 'N' update rendering

#004DC0FD   EB 0A          JMP SHORT 4DC109  // fix zoom-out center deviation
#004DC0FF   909090         NOP

#004DD20C   EB 68          JMP SHORT 4DD276  // keep wdf dimensions
#004DD20E   90             NOP

F7 401AC3
pause/break 401B1A

Thank you, I had the idea to use info on F6 monster key from my random events project (I guess F7 is a typo?). Also your pause/break is mudd research.

Since only 'O' hotkey has rendering issues (not overlay button) a simple two bytes jump to 'N' end code was easier.

EDIT: I did not test possible rendering issues with mapAI data (just diagnostics, unused by default): viewtopic.php?p=34204#p34204

[thunderchero]

Optimised/shortened dynamic patch (dimensions read from wdf, works for all resolutions):

great job

F7 401AC3
pause/break 401B1A

Thank you, I had the idea to use info on F6 monster key from my random events project (I guess F7 is a typo?). Also your pause/break is mudd research.

correct 401B1A is F9 (screen is still active after breakpoint triggered ) So when pause/break was used it also triggered "invalid handle" after invalid handle I must close app.

with breakpoint at 401AC3 when "F7" is used it triggers breakpoint.

before I start major editing,
1. Large patches for ecm, are you happy with "80 pixels per sector" for zoom? personally I prefer "60" but it is up to you and is easily edited by user with UE. or should I set zoom pixels to same height as vanilla? example vanilla 800 x 600 displays 6 sectors (top to bottom) so all version (res and map size) would display 6 sectors top to bottom when in zoom.
2. will min minors patch be added to base ECM or does it need to be part of large map patches? or neither?

I need to start a "to do" list so I don't forget things.....