Adding the Minor Race Personality in Race Info Screen?

[Spocks-cuddly-tribble]

I think adding the personality (warlike, peaceful, pacifist, deceptive or spiritual) after name in Race Info would be a useful patch (hidden trait):

Race_Info.png (258.94 KiB) Viewed 5885 times

Editing the first contact popup is not needed IMHO:

First_Contact.png (86.88 KiB) Viewed 5885 times

Personality is a float value read from aiminor.wtf and stored as integer at 4081D1.
So call 405F00 Load_special_AIAgent_data_eax14h and reading [eax+4] is easy. [eax+8] would be the Explorer trait.

But where is the text strings for the personalities warlike, peaceful, pacifist, deceptive and spiritual (not trek.exe, aiminor.wtf or lexicon.dic)?
How hard would be editing wdf files & code of Race Info screen (I don't even know the file names)? Just replacing the name shouldn't require editing wdf.

[thunderchero]

(I don't even know the file names)? Just replacing the name shouldn't require editing wdf.

correct should be all trek code changes

*d_rinfo.wdf called at 004C4548 is basic code area, but not seeing where race name string code is right now.

warlike, peaceful, pacifist, deceptive or spiritual

I think these descriptions were imposed by Gowron? and are never listed in any file or trek. I think even UE uses a language string to display in UE.

But this project is similar to X, Y project.

needed
strings added to data area (warlike, peaceful, pacifist, deceptive and spiritual).
not sure if a jump table or what we would use to select correct personality string
new/borrowed wild card string "%s %s"
plus code space to use all above

edit; we might be able to use something like lexicon string id160 (but think code is a random selection?)
if personality = 0 use first string, if = 1 used 2nd string ect ...
Enormous|Juggernaut|Gigantic|Colossus|Leviathan|Tremendous

[Spocks-cuddly-tribble]

*d_rinfo.wdf called at 004C4548 is basic code area

Thank you, using this information I located:

4C2410   push  eax  // name string from race.rst

Easy to create a test patch, with strings from an asm pointer, replacing the race name.
For AI empires it could display the current AI agenda (same code location), but needs an exception for other player empires in MP....

I think these descriptions were imposed by Gowron? and are never listed in any file or trek. I think even UE uses a language string to display in UE.

I can't see the personality code key in UE source code for aiminor.wtf: https://gitlab.com/stbotf/ultimate-edit ... minor.java

[thunderchero]

I can't see the personality code key in UE source code for aiminor.wtf: https://gitlab.com/stbotf/ultimate-edit ... minor.java

\ue\gui\stbof\emp\AiminorGUI.java
line 72?

[Spocks-cuddly-tribble]

Line 65... so "AiminorGUI.0" - "AiminorGUI.4" would be labels for personality values 0-4? And where is the language file with the data?

[thunderchero]

Line 65... so "AiminorGUI.0" - "AiminorGUI.4" would be labels for personality values 0-4? And where is the language file with the data?

sorry I have not had much time to look at this, but helping when I can

https://gitlab.com/stbotf/ultimate-edit ... properties

line 509

AiminorGUI.0=Warlike
AiminorGUI.1=Peaceful
AiminorGUI.2=Pacifist
AiminorGUI.3=Deceptive
AiminorGUI.4=Spiritual

[Spocks-cuddly-tribble]

Don't worry, I'm just not used to the UE java files.

My first test code reads new asm strings via Personality*10 (using 50 unused bytes).


Final patch will check for AIAgents, and for other player empires just display race name in capitals (default -> MP-proof).

Else it will compose a new string:

- race name in capitals (default) +
- 5808A0 '%s - %s'
- minor Personality or current AI empire Agenda (usual letters)

If you have a better idea, let me know.

[thunderchero]

If you have a better idea, let me know.

after helping me you might know how to add strings better than me.

as for font if it shares the string, I think all font will be the same (all capitals)

as for displaying "current AI empire Agenda" this would be interesting. not sure if this will give human player too much of an advantage.

[Spocks-cuddly-tribble]

Epic win.

Race_Info_Patch.png (312.12 KiB) Viewed 5694 times

Race_Info_Screen.patch

(2.29 KiB) Downloaded 81 times

ASM code:

► Show Spoiler

004C23E3   . 8BF4               MOV ESI,ESP
004C23E5   . 8BF8               MOV EDI,EAX
004C23E7   . 8B90 B4000000      MOV EDX,[EAX+B4]
004C23ED   . 8B40 6C            MOV EAX,[EAX+6C]
004C23F0   . 8B00               MOV EAX,[EAX]
004C23F2   . E8 D9AB0700        CALL 53CFD0
004C23F7   . 8BC3               MOV EAX,EBX
004C23F9   . E8 52C9FEFF        CALL 4AED50
004C23FE   . E8 5D93FCFF        CALL 48B760
004C2403   . 8BC7               MOV EAX,EDI
004C2405   . 8B5424 38          MOV EDX,[ESP+38]
004C2409   . 8B80 BC000000      MOV EAX,[EAX+BC]
004C240F   . E8 4CF70700        CALL 541B60
004C2414   . 8BD4               MOV EDX,ESP
004C2416   . 8BC3               MOV EAX,EBX
004C2418   . E8 A328F4FF        CALL 404CC0
004C241D   . 85C0               TEST EAX,EAX
004C241F   . 74 27              JE SHORT 4C2448
004C2421   . 0FBF00             MOVSX EAX,WORD[EAX]
004C2424   . E8 D73AF4FF        CALL 405F00
004C2429   . 80FB 05            CMP BL,5
004C242C   . 72 0B              JB SHORT 4C2439
004C242E   . 6B40 04 0A         IMUL EAX,[EAX+4],0A
004C2432   . 05 23544E00        ADD EAX, 4E5423                    ;  ASCII "Warlike"
004C2437   . EB 0A              JMP SHORT 4C2443
004C2439   > 8B40 04            MOV EAX,[EAX+4]
004C243C   . 8B0485 B0504E00    MOV EAX,[EAX*4+4E50B0]             ;  ASCII Agenda(s)
004C2443   > E9 0D300200        JMP 4E5455
004C2448   > 8BC7               MOV EAX,EDI
004C244A   . 8B80 B8000000      MOV EAX,[EAX+B8]
004C2450   . E8 0BF70700        CALL 541B60
004C2455   . 8BC7               MOV EAX,EDI
004C2457   . 8B80 C0000000      MOV EAX,[EAX+C0]
004C245D   . 8B00               MOV EAX,[EAX]
004C245F   . 8BC8               MOV ECX,EAX
004C2461   . 80FB 05            CMP BL,5

004C2532     8BC3               MOV EAX,EBX


004E50B0   18175800      DD trek.00581718    ;  ASCII "Normal Expansion"
004E50B4   2C175800      DD trek.0058172C    ;  ASCII "Unopposed Expansion"
004E50B8   40175800      DD trek.00581740    ;  ASCII "Normal Consolidation"
004E50BC   58175800      DD trek.00581758    ;  ASCII "Defensive Consolidation"
004E50C0   70175800      DD trek.00581770    ;  ASCII "Offensive Consolidation"
004E50C4   88175800      DD trek.00581788    ;  ASCII "Cold War"
004E50C8   94175800      DD trek.00581794    ;  ASCII "Defensive War"
004E50CC   A4175800      DD trek.005817A4    ;  ASCII "Offensive War"
004E50D0   B4175800      DD trek.005817B4    ;  ASCII "Jihad"

004E5187     8B0485 B0504E00      MOV EAX,[EAX*4+4E50B0]   // AI Agenda string
004E518E     9090909090           NOP

004E5423  57 61 72 6C 69 6B 65 00         ASCII "Warlike"
004E542D  50 65 61 63 65 66 75 6C 00      ASCII "Peaceful"
004E5437  50 61 63 69 66 69 73 74 00      ASCII "Pacifist"
004E5441  44 65 63 65 70 74 69 76 65 00   ASCII "Deceptive"
004E544B  53 70 69 72 69 74 75 61 6C 00   ASCII "Spiritual"

004E5455     50                PUSH EAX
004E5456     52                PUSH EDX
004E5457     68 A0085800       PUSH 5808A0                       ;  ASCII "%s - %s"
004E545C     8D4424 3C         LEA EAX,[ESP+3C]
004E5460     50                PUSH EAX
004E5461     E8 33E90200       CALL 513D99
004E5466     83C4 10           ADD ESP,10
004E5469     8D5424 30         LEA EDX,[ESP+30]
004E546D    ^E9 D6CFFDFF       JMP 4C2448
004E5472     90                NOP

as for displaying "current AI empire Agenda" this would be interesting. not sure if this will give human player too much of an advantage.

I'm not aware of any AI agenda which doesn't translate into 'hardcore Pakled', so no worry. Plus 'Jihad' still needs more research.

[thunderchero]

Epic win. Patch will be released after more tests.

as for font if it shares the string, I think all font will be the same (all capitals)

No, I don't think so:

nice, look forward to patch.

btw I was thinking that was 28.fnt (no lower case in file)

the only thing I wonder about is using race list area some mods with edited majors/minors might have overlap
although all mods I checked had room for 50 bytes

[Spocks-cuddly-tribble]

Patch released in above post. Multiplayer tests would be useful before use in public mods.

the only thing I wonder about is using race list area some mods with edited majors/minors might have overlap

Post was edited and query removed since I optimised patch and relocated new strings to a safe area.

I just noticed the vanilla/ECM Bynars are Warlike by default.

[thunderchero]

Multiplayer tests would be useful before use in public mods.

Quick MP test, patch looks good
(test done on patched vanilla)
if human player

human.jpg (469.75 KiB) Viewed 5645 times

if AI

ai.jpg (485.79 KiB) Viewed 5645 times

[Spocks-cuddly-tribble]

1.) AI wants to go to war vs a weaker empire but has no valid invade targets in medium range:

Bug/bias = defensive war -> should be offensive so the AI can get closer (defensive = new stations only in own territory)


2.) AI at the brink of annihilation vs a stronger enemy but also at war vs a weaker empire with valid invade targets:

Bug/bias = offensive war -> should be defensive (or even Jihad?)


3.) Jihad = open war vs a stronger but not more than twice as powerful (bug?) enemy who broke 3+ treaties

Trigger using unfinished features (second hidden attitude value) should be optimised/fixed, but leads to 'dumb' random ramming in combat.

[Tethys]

Epic win.


Race_Info_Patch.png



Race_Info_Screen.patch


ASM code:

► Show Spoiler

004C23E3   . 8BF4               MOV ESI,ESP
004C23E5   . 8BF8               MOV EDI,EAX
004C23E7   . 8B90 B4000000      MOV EDX,[EAX+B4]
004C23ED   . 8B40 6C            MOV EAX,[EAX+6C]
004C23F0   . 8B00               MOV EAX,[EAX]
004C23F2   . E8 D9AB0700        CALL 53CFD0
004C23F7   . 8BC3               MOV EAX,EBX
004C23F9   . E8 52C9FEFF        CALL 4AED50
004C23FE   . E8 5D93FCFF        CALL 48B760
004C2403   . 8BC7               MOV EAX,EDI
004C2405   . 8B5424 38          MOV EDX,[ESP+38]
004C2409   . 8B80 BC000000      MOV EAX,[EAX+BC]
004C240F   . E8 4CF70700        CALL 541B60
004C2414   . 8BD4               MOV EDX,ESP
004C2416   . 8BC3               MOV EAX,EBX
004C2418   . E8 A328F4FF        CALL 404CC0
004C241D   . 85C0               TEST EAX,EAX
004C241F   . 74 27              JE SHORT 4C2448
004C2421   . 0FBF00             MOVSX EAX,WORD[EAX]
004C2424   . E8 D73AF4FF        CALL 405F00
004C2429   . 80FB 05            CMP BL,5
004C242C   . 72 0B              JB SHORT 4C2439
004C242E   . 6B40 04 0A         IMUL EAX,[EAX+4],0A
004C2432   . 05 23544E00        ADD EAX, 4E5423                    ;  ASCII "Warlike"
004C2437   . EB 0A              JMP SHORT 4C2443
004C2439   > 8B40 04            MOV EAX,[EAX+4]
004C243C   . 8B0485 B0504E00    MOV EAX,[EAX*4+4E50B0]             ;  ASCII Agenda(s)
004C2443   > E9 0D300200        JMP 4E5455
004C2448   > 8BC7               MOV EAX,EDI
004C244A   . 8B80 B8000000      MOV EAX,[EAX+B8]
004C2450   . E8 0BF70700        CALL 541B60
004C2455   . 8BC7               MOV EAX,EDI
004C2457   . 8B80 C0000000      MOV EAX,[EAX+C0]
004C245D   . 8B00               MOV EAX,[EAX]
004C245F   . 8BC8               MOV ECX,EAX
004C2461   . 80FB 05            CMP BL,5

004C2532     8BC3               MOV EAX,EBX


004E50B0   18175800      DD trek.00581718    ;  ASCII "Normal Expansion"
004E50B4   2C175800      DD trek.0058172C    ;  ASCII "Unopposed Expansion"
004E50B8   40175800      DD trek.00581740    ;  ASCII "Normal Consolidation"
004E50BC   58175800      DD trek.00581758    ;  ASCII "Defensive Consolidation"
004E50C0   70175800      DD trek.00581770    ;  ASCII "Offensive Consolidation"
004E50C4   88175800      DD trek.00581788    ;  ASCII "Cold War"
004E50C8   94175800      DD trek.00581794    ;  ASCII "Defensive War"
004E50CC   A4175800      DD trek.005817A4    ;  ASCII "Offensive War"
004E50D0   B4175800      DD trek.005817B4    ;  ASCII "Jihad"

004E5187     8B0485 B0504E00      MOV EAX,[EAX*4+4E50B0]   // AI Agenda string
004E518E     9090909090           NOP

004E5423  57 61 72 6C 69 6B 65 00         ASCII "Warlike"
004E542D  50 65 61 63 65 66 75 6C 00      ASCII "Peaceful"
004E5437  50 61 63 69 66 69 73 74 00      ASCII "Pacifist"
004E5441  44 65 63 65 70 74 69 76 65 00   ASCII "Deceptive"
004E544B  53 70 69 72 69 74 75 61 6C 00   ASCII "Spiritual"

004E5455     50                PUSH EAX
004E5456     52                PUSH EDX
004E5457     68 A0085800       PUSH 5808A0                       ;  ASCII "%s - %s"
004E545C     8D4424 3C         LEA EAX,[ESP+3C]
004E5460     50                PUSH EAX
004E5461     E8 33E90200       CALL 513D99
004E5466     83C4 10           ADD ESP,10
004E5469     8D5424 30         LEA EDX,[ESP+30]
004E546D    ^E9 D6CFFDFF       JMP 4C2448
004E5472     90                NOP

as for displaying "current AI empire Agenda" this would be interesting. not sure if this will give human player too much of an advantage.

I'm not aware of any AI agenda which doesn't translate into 'hardcore Pakled', so no worry. Plus 'Jihad' still needs more research.

Does the text update if their expansion agenda changes? If so, this is complete genius

[Spocks-cuddly-tribble]

Does the text update if their expansion agenda changes?

Yes, it's the agenda string used in 'map ai data type' E: viewtopic.php?p=34204#p34204